Stop polluting the global namespace with test code and add shared,

checkout-specific tmpdir support in spec helper.

Author: rsutphin

spec/bcdatabase/commands_spec.rb

@@ -8,13 +8,12 @@ module Bcdatabase::Commands
   before do
     pending('Issue #7') if RUBY_VERSION > '1.9'
 
-    ENV["BCDATABASE_PATH"] = "/tmp/bcdb_specs"
+    ENV["BCDATABASE_PATH"] = tmpdir + 'bcdb_specs'
     FileUtils.mkdir_p ENV["BCDATABASE_PATH"]
   end
 
   after(:each) do
     if RUBY_VERSION < '1.9'
-      FileUtils.rm_rf ENV["BCDATABASE_PATH"]
       ENV["BCDATABASE_PATH"] = nil
     end
   end

spec/bcdatabase_spec.rb

@@ -2,7 +2,7 @@
 
 describe Bcdatabase do
   before(:each) do
-    ENV["BCDATABASE_PATH"] = "/tmp/bcdb_specs"
+    ENV["BCDATABASE_PATH"] = tmpdir + 'bcdb_specs'
     FileUtils.mkdir_p ENV["BCDATABASE_PATH"]
   end
 
@@ -13,13 +13,12 @@
 
   describe "cipherment" do
     before(:all) do
-      keyfile = "/tmp/bcdb-spec-key"
+      keyfile = tmpdir + 'bcdb-spec-key'
       open(keyfile, 'w') { |f| f.write "01234567890123456789012345678901" }
       ENV["BCDATABASE_PASS"] = keyfile
     end
 
     after(:all) do
-      FileUtils.rm ENV["BCDATABASE_PASS"]
       ENV["BCDATABASE_PASS"] = nil
     end
 

spec/spec_helper.rb

@@ -2,42 +2,78 @@
 
 require 'bcdatabase'
 require 'fileutils'
+require 'pathname'
 
-def temporary_yaml(name, hash)
-  filename = "/#{ENV['BCDATABASE_PATH']}/#{name}.yaml"
-  open(filename, "w") { |f| YAML.dump(hash, f) }
-  filename
-end
+module Bcdatabase::Spec
+  module Helpers
+    def self.use_in(rspec_config)
+      rspec_config.include self
+      rspec_config.after do
+        clear_tmpdir
+      end
+    end
 
-def capture_std
-  so = StringIO.new
-  se = StringIO.new
-  $stdout = so
-  $stderr = se
-  yield
-  { :out => so.string, :err => se.string }
-ensure
-  $stdout = STDOUT
-  $stderr = STDERR
-end
+    def tmpdir
+      @tmpdir ||= Pathname.new(File.expand_path('../tmp', __FILE__)).tap do |tmp|
+        tmp.mkpath
+      end
+    end
 
-def enable_fake_cipherment
-  # replace real encryption methods with something predictable
-  Bcdatabase.module_eval do
-    class << self
-      alias :encrypt_original :encrypt
-      alias :decrypt_original :decrypt
-      def encrypt(s); s.reverse; end
-      def decrypt(s); s.reverse; end
+    def clear_tmpdir
+      if @tmpdir
+        @tmpdir.rmtree
+      end
+    end
+    module_function :clear_tmpdir
+
+    def temporary_yaml(name, hash)
+      filename = "/#{ENV['BCDATABASE_PATH']}/#{name}.yaml"
+      open(filename, "w") { |f| YAML.dump(hash, f) }
+      filename
     end
-  end
-end
 
-def disable_fake_cipherment
-  Bcdatabase.module_eval do
-    class << self
-      alias :encrypt :encrypt_original
-      alias :decrypt :decrypt_original
+    def capture_std
+      so = StringIO.new
+      se = StringIO.new
+      $stdout = so
+      $stderr = se
+      yield
+      { :out => so.string, :err => se.string }
+    ensure
+      $stdout = STDOUT
+      $stderr = STDERR
+    end
+
+    def replace_stdin(*lines)
+      $stdin = StringIO.new(lines.join("\n"))
+      yield
+    ensure
+      $stdin = STDIN
+    end
+
+    def enable_fake_cipherment
+      # replace real encryption methods with something predictable
+      Bcdatabase.module_eval do
+        class << self
+          alias :encrypt_original :encrypt
+          alias :decrypt_original :decrypt
+          def encrypt(s); s.reverse; end
+          def decrypt(s); s.reverse; end
+        end
+      end
+    end
+
+    def disable_fake_cipherment
+      Bcdatabase.module_eval do
+        class << self
+          alias :encrypt :encrypt_original
+          alias :decrypt :decrypt_original
+        end
+      end
     end
   end
 end
+
+RSpec.configure do |config|
+  Bcdatabase::Spec::Helpers.use_in(config)
+end