Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommandResult is not always the array we expect #18

Closed
swentel opened this issue Mar 10, 2023 · 3 comments
Closed

CommandResult is not always the array we expect #18

swentel opened this issue Mar 10, 2023 · 3 comments
Assignees
@Sebastix

Comments

@swentel
Copy link
Collaborator

swentel commented Mar 10, 2023

e.g.

["NOTICE","invalid: "pubkey" is required"]
So check that in Relay::send()
@swentel swentel mentioned this issue Mar 10, 2023
Closed
@swentel
Copy link
Collaborator Author

swentel commented Mar 10, 2023

A success call crashes too with this one though, so let's check what exactly changed before #14

swentel added a commit that referenced this issue Mar 10, 2023
@swentel
Relay response is not always an array #18
bb279c6
@swentel swentel changed the title Relay response is not always an array Relay response is not always the array we excpect Mar 10, 2023
@swentel swentel changed the title Relay response is not always the array we excpect CommandResponse is not always the array we expect Mar 10, 2023
@swentel
Copy link
Collaborator Author

swentel commented Mar 10, 2023

Ok, fixed the response in Relay, that was already broken, but let's make sure we don't fatal here and catch other responses from the relay too.

@swentel swentel changed the title CommandResponse is not always the array we expect CommandResult is not always the array we expect Mar 10, 2023
@Sebastix Sebastix self-assigned this Nov 29, 2023
@Sebastix
Copy link
Member

Closing this issue, see #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sebastix Sebastix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swentel @Sebastix