Skip to content

Update documentation and dependencies #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
machow opened this issue Sep 19, 2015 · 1 comment
Open

Update documentation and dependencies #14

machow opened this issue Sep 19, 2015 · 1 comment

Comments

@machow
Copy link

machow commented Sep 19, 2015

I just got the jupyter-nodejs notebook up and running and it looks great! There were a few bumps, and holes in the documentation along the way, so I thought I'd leave them here, in case they're useful.

  1. zmq is a dependency (for zeromq.node)
  2. the README.md is pointing to an old release, so grabbing the master branch fixed several issues
  3. need to run make at the end

I don't mind making the changes and submitting a pull request, but figured I'd check beforehand.
@jaredly
Copy link
Member

jaredly commented Sep 20, 2015

That sounds great, thanks for the feedback! Your pull request will be welcome

akosel pushed a commit to akosel/jupyter-nodejs that referenced this issue Jul 11, 2016
List ZeroMQ as dependency. Add make to install.
9fa45b4 
Addresses issues listed here: notablemind#14
@akosel akosel mentioned this issue Jul 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaredly @machow