Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename extension name from polkadot-js to nova-wallet #1394

Open
laurogripa opened this issue Feb 19, 2025 · 1 comment
Open

Rename extension name from polkadot-js to nova-wallet #1394

laurogripa opened this issue Feb 19, 2025 · 1 comment

Comments

@laurogripa
Copy link

I'm opening an issue here because it seems like a more appropriate place.

You can check another issue opened by another user on the js dapp repo (& my reasoning) in this link, but I will replicate most of my comment here too for clarity...

Right now, Nova's extension name is polkadot-js, which can be confusing for new dapps trying to add Nova support. They have to implement a workaround, treating Nova's extension name as polkadot-js, and using mobile detection to differentiate between mobile & desktop browsers to decide which polkadot-js to show, or else it can get very confusing for users.

It's the case for Hydra's UI, see here:
https://github.com/galacticcouncil/hydration-ui/blob/master/src/sections/web3-connect/wallets/NovaWallet.ts

And here:
https://github.com/galacticcouncil/hydration-ui/blob/ede41140bb69cc0aea9a22ccdda4d39446a3c6d8/src/sections/web3-connect/constants/providers.ts

It's not a huge problem, it can be worked around, but it's a bad DevX for newcomers. It sounds like a very simple fix, we just need to be aware that changing the extension name might break a lot (if not all) UIs that support Nova in the ecosystem. I think it needs to be a coordinated fix.

@ERussel
Copy link
Collaborator

ERussel commented Feb 19, 2025

Hey Lauro! Thank you for raising the issue. We are planing to add a separate extension name for the Nova Wallet. I will let you know in the issue once it is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants