Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geocode fails with newer version of axios #26

Open
wijskinner opened this issue Jul 21, 2022 · 0 comments
Open

Geocode fails with newer version of axios #26

wijskinner opened this issue Jul 21, 2022 · 0 comments

Comments

@wijskinner
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Newer versions of axios (27.02 required in my project) mangle the countrycodes array and the geocode therefore fails. This patch fixes that.

Here is the diff that solved my problem:

diff --git a/node_modules/nominatim-browser/dist/nominatim-browser.js b/node_modules/nominatim-browser/dist/nominatim-browser.js
index 21bf6d3..e195457 100644
--- a/node_modules/nominatim-browser/dist/nominatim-browser.js
+++ b/node_modules/nominatim-browser/dist/nominatim-browser.js
@@ -35,6 +35,10 @@ function createRequest(path, data, nominatimUrl) {
     if (data === void 0) { data = {}; }
     //Result should be in JSON
     data["format"] = "json";
+
+    if (data && data.countrycodes) {
+        data.countrycodes = data.countrycodes.reduce((f, s) => `${f},${s}`)
+    }
     var request = Axios({
         url: nominatimUrl + "/" + path,
         method: "GET",

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant