Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IAsyncDisposable #2597

Closed
roji opened this issue Aug 30, 2019 · 2 comments · Fixed by #2600
Closed

Implement IAsyncDisposable #2597

roji opened this issue Aug 30, 2019 · 2 comments · Fixed by #2600
Assignees
@roji
Labels
enhancement
Milestone
4.1.0

Comments

@roji
Copy link
Member

roji commented Aug 30, 2019

dotnet/corefx#37877 added IAsyncDisposable on DbConnection, DbCommand, DbDataReader - we need to override DisposeAsync to actually enable async disposal.
@roji roji added this to the 4.1 milestone Aug 30, 2019
@roji roji self-assigned this Aug 30, 2019
roji added a commit that referenced this issue Sep 1, 2019
@roji
Implement DisposeAsync
4fd2b6c 
The main scenario to be handled asynchronously, is when a connection
(or transaction) is disposed by an open reader is still active, with
its resultset needing to be consumed.

Fixes #2597
@roji roji mentioned this issue Sep 1, 2019
Merged
roji added a commit that referenced this issue Sep 3, 2019
@roji
Implement DisposeAsync
edd0824 
The main scenario to be handled asynchronously, is when a connection
(or transaction) is disposed by an open reader is still active, with
its resultset needing to be consumed.

Fixes #2597
@roji roji closed this as completed in #2600 Sep 3, 2019
roji added a commit that referenced this issue Sep 3, 2019
@roji
Implement DisposeAsync
8b186c6 
The main scenario to be handled asynchronously, is when a connection
(or transaction) is disposed by an open reader is still active, with
its resultset needing to be consumed.

Fixes #2597
@mikkeljohnsen
Copy link

mikkeljohnsen commented Oct 3, 2019 •
edited
Loading

How do I use the netstandard2.0 version of 4.1.1 with the normal framework. I'm getting

error CS7069: Reference to type 'IAsyncDisposable' claims it is defined in 'mscorlib', but it could not be found

I'm compiling with:

csc -nologo -nowarn:CS0649,CS0169 -nostdlib -noconfig -langversion:7.3 -r:/usr/lib/mono/4.7.2-api/mscorlib.dll -r:/usr/lib/mono/4.7.2-api/Facades/netstandard.dll -r:/usr/lib/mono/4.7.2-api/System.dll -r:System.Core.dll -r:System.Data.dll -r:/usr/lib/mono/System.Threading.Tasks.Extensions/System.Threading.Tasks.Extensions.dll -r:/usr/lib/System.Runtime.CompilerServices.Unsafe.dll -r:/usr/lib/mono/System.Buffers/System.Buffers.dll -r:/usr/lib/mono/System.Memory/System.Memory.dll -r:/usr/lib/System.Numerics.Vectors.dll -r:/usr/lib/mono/Npgsql/Npgsql.dll`

@mikkeljohnsen
Copy link

Sorry, there must be something wrong with Mono 6.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
enhancement
Projects
None yet
Milestone
4.1.0
Development

Successfully merging a pull request may close this issue.

Implement DisposeAsync npgsql/npgsql
2 participants
@roji @mikkeljohnsen