Skip to content

Commit 60faa90

Browse files
committed
feat(libnpmversion)!: remove silent option
BREAKING CHANGE: libnpmversion no longer takes a `silent` option to suppress output from `@npmcli/run-script`. That output is now emitted via an `output` event on `process`.
1 parent 39e4da0 commit 60faa90

File tree

4 files changed

+0
-6
lines changed

4 files changed

+0
-6
lines changed

workspaces/libnpmversion/README.md

-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ npmVersion(arg, {
3131
ignoreScripts: false, // do not run pre/post/version lifecycle scripts
3232
scriptShell: '/bin/bash', // shell to run lifecycle scripts in
3333
message: 'v%s', // message for tag and commit, replace %s with the version
34-
silent: false, // passed to @npmcli/run-script to control whether it logs
3534
}).then(newVersion => {
3635
console.error('version updated!', newVersion)
3736
})

workspaces/libnpmversion/lib/index.js

-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ module.exports = async (newversion, opts = {}) => {
1515
scriptShell = undefined,
1616
preid = null,
1717
message = 'v%s',
18-
silent,
1918
} = opts
2019

2120
const pkg = opts.pkg || await readJson(path + '/package.json')
@@ -35,6 +34,5 @@ module.exports = async (newversion, opts = {}) => {
3534
preid,
3635
pkg,
3736
message,
38-
silent,
3937
})
4038
}

workspaces/libnpmversion/lib/version.js

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ module.exports = async (newversion, opts) => {
2020
ignoreScripts,
2121
preid,
2222
pkg,
23-
silent,
2423
} = opts
2524

2625
const { valid, clean, inc } = semver

workspaces/libnpmversion/tap-snapshots/test/index.js.test.cjs

-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ Array [
2424
"scriptShell": undefined,
2525
"signGitCommit": false,
2626
"signGitTag": false,
27-
"silent": undefined,
2827
"tagVersionPrefix": "v",
2928
},
3029
]
@@ -49,7 +48,6 @@ Array [
4948
"scriptShell": "/bin/bash",
5049
"signGitCommit": true,
5150
"signGitTag": true,
52-
"silent": undefined,
5351
"tagVersionPrefix": "=",
5452
},
5553
]

0 commit comments

Comments
 (0)