fix(arborist): check placed node children for missing deps (#7746)

This addresses an edge case where a dep could be placed in the tree
with unsatisfied indirect dependencies (see test case).

Author: Trevor Burnham

workspaces/arborist/lib/arborist/build-ideal-tree.js

@@ -988,8 +988,12 @@ This is a one-time fix-up, please be patient...
           }
 
           // lastly, also check for the missing deps of the node we placed,
+          // as well as any missing deps of the new node's children,
           // and any holes created by pruning out conflicted peer sets.
           this.#depsQueue.push(placed)
+          for (const child of placed.children.values()) {
+            this.#depsQueue.push(child)
+          }
           for (const dep of pd.needEvaluation) {
             this.#depsSeen.delete(dep)
             this.#depsQueue.push(dep)

workspaces/arborist/test/arborist/reify.js

@@ -539,6 +539,15 @@ t.test('update a node without updating a child that has bundle deps', t => {
   }))
 })
 
+t.only('restore missing parent while preserving child node', async t => {
+  const path = fixture(t, 'lockfile-with-missing-parent')
+  await reify(path)
+  const parentPath = `${path}/node_modules/globby`
+  t.equal(fs.statSync(`${parentPath}/package.json`).isFile(), true, 'parent has package.json')
+  const childPath = `${path}/node_modules/globby/node_modules/minimatch`
+  t.equal(fs.statSync(`${childPath}/package.json`).isFile(), true, 'child has package.json')
+})
+
 t.test('optional dependency failures', t => {
   const cases = [
     'optional-dep-tgz-missing',

workspaces/arborist/test/fixtures/lockfile-with-missing-parent/package-lock.json

@@ -0,0 +1,9 @@
+{
+  "name": "lockfile-with-missing-parent",
+  "version": "1.0.0",
+  "dependencies": {
+    "glob": "7.1.6",
+    "globby": "1.2.0",
+    "minimatch": "3.0.3"
+  }
+}