From 47b928ccefe1f3fc450e4d7df5058bac8a6090f6 Mon Sep 17 00:00:00 2001
From: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Date: Mon, 25 Nov 2024 11:18:52 -0500
Subject: [PATCH] deps: replace node builtin rmSync with rimraf (#412)

This avoids the EBUSY issue during "spawn daemon" test mentioned in
https://github.com/npm/pacote/pull/408
---
 package.json | 1 +
 test/git.js  | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/package.json b/package.json
index 335c7a6c..7a840494 100644
--- a/package.json
+++ b/package.json
@@ -33,6 +33,7 @@
     "mutate-fs": "^2.1.1",
     "nock": "^13.2.4",
     "npm-registry-mock": "^1.3.2",
+    "rimraf": "^6.0.1",
     "tap": "^16.0.1"
   },
   "files": [
diff --git a/test/git.js b/test/git.js
index 007446fc..2db2675b 100644
--- a/test/git.js
+++ b/test/git.js
@@ -3,12 +3,12 @@ const fs = require('node:fs')
 const http = require('node:http')
 const { dirname, basename, resolve } = require('node:path')
 const { mkdir } = require('node:fs/promises')
-const { rmSync } = require('node:fs')
 const { spawn } = require('node:child_process')
 const Arborist = require('@npmcli/arborist')
 const HostedGit = require('hosted-git-info')
 const npa = require('npm-package-arg')
 const spawnGit = require('@npmcli/git').spawn
+const rimraf = require('rimraf')
 const tar = require('tar')
 const spawnNpm = require('../lib/util/npm.js')
 const GitFetcher = require('../lib/git.js')
@@ -229,7 +229,8 @@ t.test('setup', { bail: true, skip: isWindows && 'posix only' }, t => {
     }
     daemon.stderr.on('data', onDaemonData)
     // only clean up the dir once the daemon is banished
-    daemon.on('close', () => rmSync(me, { recursive: true, force: true }))
+    // do NOT replace this with node's internal rmSync.  It generates EBUSY errors in windows.
+    daemon.on('close', () => rimraf.sync(me))
   })
 
   t.test('create a repo with a submodule', () => {