Skip to content

Commit 68b1095

Browse files
committed
feat: technical debt improvement
- http security filter chan updated with permissionsPolicy to replace permissionsPolicyHeader - @MockBean replaced with @MockitoBean - @SpyBean replaced with @MockitoSpyBean
1 parent 0d38eb9 commit 68b1095

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

Diff for: src/test/java/com/github/nramc/dev/journey/api/gateway/MailServiceTest.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212
import org.springframework.beans.factory.annotation.Autowired;
1313
import org.springframework.boot.autoconfigure.mail.MailSenderAutoConfiguration;
1414
import org.springframework.boot.test.context.SpringBootTest;
15-
import org.springframework.boot.test.mock.mockito.SpyBean;
1615
import org.springframework.mail.SimpleMailMessage;
1716
import org.springframework.mail.javamail.JavaMailSender;
1817
import org.springframework.test.context.ActiveProfiles;
1918
import org.springframework.test.context.DynamicPropertyRegistry;
2019
import org.springframework.test.context.DynamicPropertySource;
20+
import org.springframework.test.context.bean.override.mockito.MockitoSpyBean;
2121
import org.testcontainers.containers.GenericContainer;
2222
import org.testcontainers.containers.wait.strategy.Wait;
2323
import org.testcontainers.junit.jupiter.Container;
@@ -53,10 +53,10 @@ static void configureMail(DynamicPropertyRegistry registry) {
5353
}
5454

5555
@Autowired
56-
private MailService mailService;
56+
MailService mailService;
5757

58-
@SpyBean
59-
private JavaMailSender emailSender;
58+
@MockitoSpyBean
59+
JavaMailSender emailSender;
6060

6161
@Test
6262
void context() {

Diff for: src/test/java/com/github/nramc/dev/journey/api/web/resources/rest/users/delete/DeleteUserResourceTest.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.github.nramc.dev.journey.api.web.resources.rest.users.delete;
22

3-
import com.github.nramc.dev.journey.api.config.security.WebSecurityConfig;
43
import com.github.nramc.dev.journey.api.config.security.InMemoryUserDetailsConfig;
4+
import com.github.nramc.dev.journey.api.config.security.WebSecurityConfig;
55
import com.github.nramc.dev.journey.api.config.security.WithMockAdministratorUser;
66
import com.github.nramc.dev.journey.api.config.security.WithMockAuthenticatedUser;
77
import com.github.nramc.dev.journey.api.config.security.WithMockGuestUser;
@@ -10,12 +10,12 @@
1010
import org.junit.jupiter.api.Test;
1111
import org.springframework.beans.factory.annotation.Autowired;
1212
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
13-
import org.springframework.boot.test.mock.mockito.SpyBean;
1413
import org.springframework.context.annotation.Import;
1514
import org.springframework.security.provisioning.UserDetailsManager;
1615
import org.springframework.security.test.context.support.WithAnonymousUser;
1716
import org.springframework.security.test.context.support.WithMockUser;
1817
import org.springframework.test.context.ActiveProfiles;
18+
import org.springframework.test.context.bean.override.mockito.MockitoSpyBean;
1919
import org.springframework.test.web.servlet.MockMvc;
2020

2121
import static com.github.nramc.dev.journey.api.core.domain.user.Role.Constants.AUTHENTICATED_USER;
@@ -36,9 +36,9 @@
3636
@ActiveProfiles({"prod", "test"})
3737
class DeleteUserResourceTest {
3838
@Autowired
39-
private MockMvc mockMvc;
40-
@SpyBean
41-
private UserDetailsManager userDetailsManager;
39+
MockMvc mockMvc;
40+
@MockitoSpyBean
41+
UserDetailsManager userDetailsManager;
4242

4343
@Test
4444
void context() {

0 commit comments

Comments
 (0)