Skip to content

Commit 56cfdce

Browse files
jfischer-notmon-nordic
authored andcommitted
[nrf fromtree] usb: device_next: fix cdc_acm_send_notification()
Fix "warning: 'cdc_acm_send_notification' defined but not used" when Kconfig option UART_USE_RUNTIME_CONFIGURE is not used and properly handle enqueue error. Signed-off-by: Johann Fischer <[email protected]> (cherry picked from commit 7b34456) Signed-off-by: Tomasz Moń <[email protected]>
1 parent 8277f97 commit 56cfdce

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

subsys/usb/device_next/class/usbd_cdc_acm.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -493,8 +493,8 @@ static int usbd_cdc_acm_init(struct usbd_class_data *const c_data)
493493
return 0;
494494
}
495495

496-
static int cdc_acm_send_notification(const struct device *dev,
497-
const uint16_t serial_state)
496+
static inline int cdc_acm_send_notification(const struct device *dev,
497+
const uint16_t serial_state)
498498
{
499499
struct cdc_acm_notification notification = {
500500
.bmRequestType = 0xA1,
@@ -528,7 +528,11 @@ static int cdc_acm_send_notification(const struct device *dev,
528528

529529
net_buf_add_mem(buf, &notification, sizeof(struct cdc_acm_notification));
530530
ret = usbd_ep_enqueue(c_data, buf);
531-
/* FIXME: support for sync transfers */
531+
if (ret) {
532+
net_buf_unref(buf);
533+
return ret;
534+
}
535+
532536
k_sem_take(&data->notif_sem, K_FOREVER);
533537

534538
return ret;

0 commit comments

Comments
 (0)