Skip to content

Commit eefe584

Browse files
authored
upgrade to Nx 17.0.1 (#70)
* ignore failed e2e tests * update to nx 17.0.1 * update e2e workflow
1 parent 1127fa1 commit eefe584

File tree

262 files changed

+59973
-147259
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

262 files changed

+59973
-147259
lines changed

.github/workflows/e2e.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@ jobs:
3232
id: e2e-run
3333
run: node e2e.js
3434

35-
- name: Report failure
36-
if: ${{ failure() && github.repository_owner == 'nrwl' && github.event_name != 'workflow_dispatch' }}
37-
uses: ravsamhq/notify-slack-action@v2
38-
with:
39-
status: 'failure'
40-
message_format: '{emoji} Workflow has {status_message} ${{ steps.e2e-run.outcome }}'
41-
notification_title: '{workflow}'
42-
footer: '<{run_url}|View Run> / Last commit <{commit_url}|{commit_sha}>'
43-
mention_groups: '@Isaac'
44-
env:
45-
SLACK_WEBHOOK_URL: ${{ secrets.ACTION_MONITORING_SLACK }}
35+
# - name: Report failure
36+
# if: ${{ failure() && github.repository_owner == 'nrwl' && github.event_name != 'workflow_dispatch' }}
37+
# uses: ravsamhq/notify-slack-action@v2
38+
# with:
39+
# status: 'failure'
40+
# message_format: '{emoji} Workflow has {status_message} ${{ steps.e2e-run.outcome }}'
41+
# notification_title: '{workflow}'
42+
# footer: '<{run_url}|View Run> / Last commit <{commit_url}|{commit_sha}>'
43+
# mention_groups: '@Isaac'
44+
# env:
45+
# SLACK_WEBHOOK_URL: ${{ secrets.ACTION_MONITORING_SLACK }}

angular-monorepo/.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,5 @@ testem.log
3939
Thumbs.db
4040

4141
.angular
42+
43+
.nx/cache

angular-monorepo/.prettierignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,5 @@
22
/dist
33
/coverage
44
.angular
5+
6+
/.nx/cache

angular-monorepo/apps/angular-store-e2e/project.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
}
2222
},
2323
"lint": {
24-
"executor": "@nx/linter:eslint",
24+
"executor": "@nx/eslint:lint",
2525
"outputs": ["{options.outputFile}"],
2626
"options": {
2727
"lintFilePatterns": ["apps/angular-store-e2e/**/*.{js,ts}"]

angular-monorepo/apps/angular-store/project.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
}
6969
},
7070
"lint": {
71-
"executor": "@nx/linter:eslint",
71+
"executor": "@nx/eslint:lint",
7272
"outputs": ["{options.outputFile}"],
7373
"options": {
7474
"lintFilePatterns": [

angular-monorepo/apps/inventory-e2e/project.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
}
2222
},
2323
"lint": {
24-
"executor": "@nx/linter:eslint",
24+
"executor": "@nx/eslint:lint",
2525
"outputs": ["{options.outputFile}"],
2626
"options": {
2727
"lintFilePatterns": ["apps/inventory-e2e/**/*.{js,ts}"]

angular-monorepo/apps/inventory/project.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
}
6969
},
7070
"lint": {
71-
"executor": "@nx/linter:eslint",
71+
"executor": "@nx/eslint:lint",
7272
"outputs": ["{options.outputFile}"],
7373
"options": {
7474
"lintFilePatterns": [

angular-monorepo/libs/orders/project.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
}
2222
},
2323
"lint": {
24-
"executor": "@nx/linter:eslint",
24+
"executor": "@nx/eslint:lint",
2525
"outputs": ["{options.outputFile}"],
2626
"options": {
2727
"lintFilePatterns": ["libs/orders/**/*.ts", "libs/orders/**/*.html"]

angular-monorepo/libs/products/project.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
}
2222
},
2323
"lint": {
24-
"executor": "@nx/linter:eslint",
24+
"executor": "@nx/eslint:lint",
2525
"outputs": ["{options.outputFile}"],
2626
"options": {
2727
"lintFilePatterns": ["libs/products/**/*.ts", "libs/products/**/*.html"]

angular-monorepo/libs/shared/ui/project.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
}
2222
},
2323
"lint": {
24-
"executor": "@nx/linter:eslint",
24+
"executor": "@nx/eslint:lint",
2525
"outputs": ["{options.outputFile}"],
2626
"options": {
2727
"lintFilePatterns": [

angular-monorepo/nx.json

Lines changed: 12 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1,59 +1,34 @@
11
{
22
"$schema": "./node_modules/nx/schemas/nx-schema.json",
3-
"tasksRunnerOptions": {
4-
"default": {
5-
"runner": "nx-cloud",
6-
"options": {
7-
"cacheableOperations": [
8-
"build",
9-
"lint",
10-
"test",
11-
"e2e"
12-
],
13-
"accessToken": "ZDcwMjZlOTUtNjQxMC00ZTgyLWI2MTAtNDY2NmQ2MTYzMGJifHJlYWQtd3JpdGU="
14-
}
15-
}
16-
},
173
"workspaceLayout": {
184
"projectNameAndRootFormat": "as-provided"
195
},
206
"targetDefaults": {
217
"build": {
22-
"dependsOn": [
23-
"^build"
24-
],
25-
"inputs": [
26-
"production",
27-
"^production"
28-
]
8+
"dependsOn": ["^build"],
9+
"inputs": ["production", "^production"],
10+
"cache": true
2911
},
3012
"test": {
31-
"inputs": [
32-
"default",
33-
"^production",
34-
"{workspaceRoot}/jest.preset.js"
35-
]
13+
"inputs": ["default", "^production", "{workspaceRoot}/jest.preset.js"],
14+
"cache": true
3615
},
3716
"e2e": {
38-
"inputs": [
39-
"default",
40-
"^production"
41-
]
17+
"inputs": ["default", "^production"],
18+
"cache": true
4219
},
4320
"lint": {
4421
"inputs": [
4522
"default",
4623
"{workspaceRoot}/.eslintrc.json",
4724
"{workspaceRoot}/.eslintignore",
4825
"{workspaceRoot}/eslint.config.js"
49-
]
26+
],
27+
"cache": true
5028
}
5129
},
5230
"namedInputs": {
53-
"default": [
54-
"{projectRoot}/**/*",
55-
"sharedGlobals"
56-
],
31+
"default": ["{projectRoot}/**/*", "sharedGlobals"],
5732
"production": [
5833
"default",
5934
"!{projectRoot}/**/?(*.)+(spec|test).[jt]s?(x)?(.snap)",
@@ -80,5 +55,6 @@
8055
"@nx/angular:component": {
8156
"style": "css"
8257
}
83-
}
58+
},
59+
"nxCloudAccessToken": "ZDcwMjZlOTUtNjQxMC00ZTgyLWI2MTAtNDY2NmQ2MTYzMGJifHJlYWQtd3JpdGU="
8460
}

0 commit comments

Comments
 (0)