Skip to content

Commit 7aa25f0

Browse files
committed
Fail if core=tarantool default server failed
Currently we stop default server in worker run loop only before the next test start. So the previous test does not account whether the Tarantool executing the test exits successfully or not. Thus we do not fail on memory leaks for example. Let's stop the server and account its exit status in test. Closes tarantool#416
1 parent dd00063 commit 7aa25f0

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

lib/test.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,7 @@ def run(self, server):
218218
sys.stdout.flush()
219219

220220
is_tap = False
221+
is_crashed = False
221222
if not self.skip:
222223
if not os.path.exists(self.tmp_result):
223224
self.is_executed_ok = False
@@ -233,6 +234,9 @@ def run(self, server):
233234
is_tap, is_ok, is_skip = self.check_tap_output()
234235
self.is_equal_result = is_ok
235236
self.skip = is_skip
237+
238+
server.stop(silent=True)
239+
is_crashed = server.current_test.is_crash_reported
236240
else:
237241
self.is_equal_result = 1
238242

@@ -250,7 +254,8 @@ def run(self, server):
250254
os.remove(self.tmp_result)
251255
elif (self.is_executed_ok and
252256
self.is_equal_result and
253-
self.is_valgrind_clean):
257+
self.is_valgrind_clean and
258+
not is_crashed):
254259
short_status = 'pass'
255260
color_stdout("[ pass ]\n", schema='test_pass')
256261
if os.path.exists(self.tmp_result):

0 commit comments

Comments
 (0)