wifi, lte, internet, energy: remove unused variables

Remove unused variables that escape compiler detection because they
are disguised as RAII idiom due to side effects in Time destructor.

Author: mplekh

src/energy/test/basic-energy-harvester-test.cc

@@ -77,8 +77,6 @@ BasicEnergyHarvesterTestCase::DoRun()
     harvester->SetNode(node);
     harvester->SetEnergySource(source);
 
-    Time now = Simulator::Now();
-
     /*
      * The energy harvester will recharge the energy source for m_timeS seconds.
      */

src/internet/test/tcp-pacing-test.cc

@@ -242,7 +242,7 @@ void
 TcpPacingTest::UpdateExpectedInterval()
 {
     double_t factor;
-    Time rtt = 2 * GetPropagationDelay();
+
     if (m_curCwnd < m_ssThresh / 2)
     {
         factor = static_cast<double>(m_pacingSsRatio) / 100;

src/internet/test/tcp-rate-ops-test.cc

@@ -569,8 +569,7 @@ TcpRateLinuxWithBufferTest::TestWithSackBlocks()
                             MakeCallback(&TcpRateOps::SkbDelivered, m_rateOps));
     }
     m_expectedAckedSacked = 5 * m_segmentSize;
-    TcpRateOps::TcpRateSample rateSample =
-        m_rateOps->GenerateSample(5 * m_segmentSize, 0, false, priorInFlight, Seconds(0));
+    m_rateOps->GenerateSample(5 * m_segmentSize, 0, false, priorInFlight, Seconds(0));
 }
 
 void

src/lte/test/lte-simple-spectrum-phy.cc

@@ -114,7 +114,6 @@ LteSimpleSpectrumPhy::StartRx(Ptr<SpectrumSignalParameters> spectrumRxParams)
 
     NS_LOG_FUNCTION(this << spectrumRxParams);
     Ptr<const SpectrumValue> rxPsd = spectrumRxParams->psd;
-    Time duration = spectrumRxParams->duration;
 
     // the device might start RX only if the signal is of a type
     // understood by this device - in this case, an LTE signal.

src/wifi/model/eht/eht-frame-exchange-manager.cc

@@ -234,8 +234,6 @@ EhtFrameExchangeManager::StartTransmission(Ptr<Txop> edca, MHz_u allowedWidth)
         }
     }
 
-    std::optional<Time> timeToCtsEnd;
-
     if (m_staMac && m_staMac->IsEmlsrLink(m_linkId))
     {
         // Cannot start a transmission on a link blocked because another EMLSR link is being used

src/wifi/model/ht/ht-phy.cc

@@ -262,7 +262,6 @@ HtPhy::GetTrainingDuration(const WifiTxVector& txVector,
                         << +nDataLtf << ")  and extension (" << +nExtensionLtf
                         << ")  LTFs numbers for HT"); // see IEEE 802.11-2016, section 19.3.9.4.6
                                                       // "HT-LTF definition"
-    Time duration = MicroSeconds(4) * (nDataLtf + nExtensionLtf);
     return MicroSeconds(4) * (1 /* HT-STF */ + nDataLtf + nExtensionLtf);
 }
 

src/wifi/test/wifi-channel-switching-test.cc

@@ -209,8 +209,6 @@ WifiChannelSwitchingTest::StateChange(uint32_t nodeId,
 void
 WifiChannelSwitchingTest::DoRun()
 {
-    Time simulationTime(Seconds(6));
-
     RngSeedManager::SetSeed(1);
     RngSeedManager::SetRun(40);
     int64_t streamNumber = 100;

src/wifi/test/wifi-emlsr-basic-exchanges-test.cc

@@ -151,8 +151,6 @@ EmlsrDlTxopTest::DoSetup()
 {
     // Channel switch delay should be less than the ICF padding duration, otherwise
     // DL TXOPs cannot be initiated on auxiliary links
-    auto delay = std::min(MicroSeconds(100),
-                          *std::min_element(m_paddingDelay.cbegin(), m_paddingDelay.cend()));
     Config::SetDefault("ns3::WifiPhy::ChannelSwitchDelay", TimeValue(MicroSeconds(75)));
 
     EmlsrOperationsTestBase::DoSetup();
@@ -778,7 +776,6 @@ EmlsrDlTxopTest::CheckResults()
         bAckRespTxEnd = bAckRespIt->startTx + WifiPhy::CalculateTxDuration(bAckRespIt->psduMap,
                                                                            bAckRespIt->txVector,
                                                                            phy->GetPhyBand());
-        auto timeout = phy->GetSifs() + phy->GetSlot() + MicroSeconds(20);
 
         // the fourth frame exchange starts a PIFS after the previous one because the AP
         // performs PIFS recovery (the initial frame in the TXOP was successfully received by

src/wifi/test/wifi-emlsr-link-switch-test.cc

@@ -2193,7 +2193,6 @@ EmlsrSwitchMainPhyBackTest::RunOne()
     m_events.emplace_back(
         WIFI_MAC_CTL_ACK,
         [=, this](Ptr<const WifiPsdu> psdu, const WifiTxVector& txVector, uint8_t linkId) {
-            const auto phyHdrDuration = WifiPhy::CalculatePhyPreambleAndHeaderDuration(txVector);
             const auto txDuration =
                 WifiPhy::CalculateTxDuration(psdu,
                                              txVector,