-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Blockchain's subscriptions API #2885
Labels
enhancement
Improving existing functionality
I4
No visible changes
S2
Regular significance
U4
Nothing urgent
Comments
AliceInHunterland
added a commit
that referenced
this issue
Dec 28, 2023
There is no need to accept rw channel. Strengthening the type to read-only will allow the caller to ensure control of reading from the provided channel. Closes #2885 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
added a commit
that referenced
this issue
Jan 9, 2024
There is no need to accept rw channel. Strengthening the type to read-only will allow the caller to ensure control of reading from the provided channel. Closes #2885 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
added a commit
that referenced
this issue
Jan 9, 2024
There is no need to accept rw channel. Strengthening the type to send-only will allow the caller to ensure control of reading from the provided channel. Closes #2885 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
added a commit
that referenced
this issue
Jan 10, 2024
There is no need to accept rw channel. Strengthening the type to send-only will allow the caller to ensure control of reading from the provided channel. Closes #2885 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
added a commit
that referenced
this issue
Jan 10, 2024
There is no need to accept rw channel. Strengthening the type to send-only will allow the caller to ensure control of reading from the provided channel. Closes #2885 Signed-off-by: Ekaterina Pavlova <[email protected]>
Impossible because of #3281 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improving existing functionality
I4
No visible changes
S2
Regular significance
U4
Nothing urgent
Do the same thing with
(*Blockchain).SubscribeFor*
methods as in #2884 and check the rest of subscriptions-capable services against this issue.The text was updated successfully, but these errors were encountered: