Skip to content

Commit

Permalink
object: Switch to object ID signature in Replicate request
Browse files Browse the repository at this point in the history
Previously, `ReplicateRequest` carried signature of the full object
field. Since IDs are object checksums, it's enough to sign the ID.

Signed-off-by: Leonard Lyubich <[email protected]>
  • Loading branch information
cthulhu-rider committed Mar 5, 2024
1 parent f3ed513 commit 119054a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions object/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -717,8 +717,7 @@ message ReplicateRequest {
// Object to be replicated.
neo.fs.v2.object.Object object = 1;

// Signature of all other request fields serialized in Protocol Buffers v3
// format in ascending order of fields.
// Signature of `object.object_id.value` field.
neo.fs.v2.refs.Signature signature = 2;
}

Expand Down
2 changes: 1 addition & 1 deletion proto-docs/object.md
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ Replicate RPC request
| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| object | [Object](#neo.fs.v2.object.Object) | | Object to be replicated. |
| signature | [neo.fs.v2.refs.Signature](#neo.fs.v2.refs.Signature) | | Signature of all other request fields serialized in Protocol Buffers v3 format in ascending order of fields. |
| signature | [neo.fs.v2.refs.Signature](#neo.fs.v2.refs.Signature) | | Signature of `object.object_id.value` field. |


<a name="neo.fs.v2.object.ReplicateResponse"></a>
Expand Down

0 comments on commit 119054a

Please sign in to comment.