morph: fix error from CalculateNonceAndVUB

The alphabetic key change event comes from the main chain with its hash, and
when calculating vub, an error is returned because there is no hash in the FS
chain. Ignore the error and calculate the value in another way.

Signed-off-by: Andrey Butusov <[email protected]>

Author: End-rey

CHANGELOG.md

@@ -25,6 +25,7 @@ Changelog for NeoFS Node
 - `neofs_node_engine_list_objects_time_bucket` metric (#3120)
 - The correct role parameter to invocation (#3127)
 - nil pointer error for `storage sanity` command (#3151)
+- Calculation of VUB when it is impossible to get the transaction height (#3134)
 
 ### Changed
 - Number of cuncurrenly handled notifications from the chain was increased from 10 to 300 for IR (#3068)

pkg/innerring/state.go

@@ -128,7 +128,11 @@ func (s *Server) voteForFSChainValidator(validators keys.PublicKeys, trigger *ut
 	if trigger != nil {
 		nonce, vub, err = s.morphClient.CalculateNonceAndVUB(*trigger)
 		if err != nil {
-			return fmt.Errorf("could not calculate nonce and `validUntilBlock` values: %w", err)
+			s.log.Debug("could not calculate nonce and `validUntilBlock` values", zap.Error(err))
+			nonce, vub, err = s.morphClient.CalculateNonceAndVUB(util.Uint256{})
+			if err != nil {
+				return fmt.Errorf("could not calculate nonce and `validUntilBlock` values for zero hash: %w", err)
+			}
 		}
 		vubP = &vub
 	}

pkg/morph/client/notary.go

@@ -268,7 +268,11 @@ func (c *Client) UpdateNotaryList(notaries keys.PublicKeys, txHash util.Uint256)
 
 	nonce, vub, err := c.CalculateNonceAndVUB(txHash)
 	if err != nil {
-		return fmt.Errorf("could not calculate nonce and `valicUntilBlock` values: %w", err)
+		c.logger.Debug("could not calculate nonce and `validUntilBlock` values", zap.Error(err))
+		nonce, vub, err = c.CalculateNonceAndVUB(util.Uint256{})
+		if err != nil {
+			return fmt.Errorf("could not calculate nonce and `validUntilBlock` values for zero hash: %w", err)
+		}
 	}
 
 	return c.notaryInvokeAsCommittee(
@@ -292,7 +296,11 @@ func (c *Client) UpdateNeoFSAlphabetList(alphas keys.PublicKeys, txHash util.Uin
 
 	nonce, vub, err := c.CalculateNonceAndVUB(txHash)
 	if err != nil {
-		return fmt.Errorf("could not calculate nonce and `valicUntilBlock` values: %w", err)
+		c.logger.Debug("could not calculate nonce and `validUntilBlock` values", zap.Error(err))
+		nonce, vub, err = c.CalculateNonceAndVUB(util.Uint256{})
+		if err != nil {
+			return fmt.Errorf("could not calculate nonce and `validUntilBlock` values for zero hash: %w", err)
+		}
 	}
 
 	return c.notaryInvokeAsCommittee(
@@ -767,6 +775,14 @@ func (c *Client) CalculateNonceAndVUB(hash util.Uint256) (nonce uint32, vub uint
 
 	nonce = binary.LittleEndian.Uint32(hash.BytesLE())
 
+	if hash.Equals(util.Uint256{}) {
+		c.logger.Debug("get zero hash to calculate nonce and vub")
+		vub, err = c.notaryTxValidationLimit(conn)
+		if err != nil {
+			return 0, 0, fmt.Errorf("could not get vub validation limit: %w", err)
+		}
+		return nonce, vub, nil
+	}
 	height, err := c.getTransactionHeight(conn, hash)
 	if err != nil {
 		return 0, 0, fmt.Errorf("could not get transaction height: %w", err)