BACKUP: node/object: Cache storage policy execution results

Signed-off-by: Leonard Lyubich <[email protected]>

Author: cthulhu-rider

cmd/neofs-node/config.go

@@ -473,6 +473,8 @@ type cfgObject struct {
 	cfgLocalStorage cfgLocalStorage
 
 	tombstoneLifetime uint64
+
+	containerNodesBuilder *containerNodesBuilder
 }
 
 type cfgNotifications struct {

cmd/neofs-node/object.go

@@ -599,32 +599,15 @@ func (c *cfg) getContainerNodesFromNetworkMap(networkMap *netmapsdk.NetMap, cnrI
 	return
 }
 
-func (c *cfg) getContainerNodesAtEpoch(cnrID cid.ID, epoch uint64) (
-	nodeSets [][]netmapsdk.NodeInfo,
-	storagePolicy netmapsdk.PlacementPolicy,
-	networkMap *netmapsdk.NetMap,
-	err error,
-) {
-	networkMap, err = c.netMapSource.GetNetMapByEpoch(epoch)
-	if err != nil {
-		err = fmt.Errorf("read network map by epoch: %w", err)
-		return
-	}
-
-	nodeSets, storagePolicy, err = c.getContainerNodesFromNetworkMap(networkMap, cnrID)
-
-	return
-}
-
 // GetContainerNodesAtEpoch reads storage policy of the referenced container
 // from the underlying container storage, reads network map at the specified
 // epoch from the underlying storage, applies the storage policy to it and
 // returns sets of selected storage nodes.
 //
 // GetContainerNodesAtEpoch implements [searchsvc.Node].
 func (c *cfg) GetContainerNodesAtEpoch(cnr cid.ID, epoch uint64) ([][]netmapsdk.NodeInfo, error) {
-	nodeSets, _, _, err := c.getContainerNodesAtEpoch(cnr, epoch)
-	return nodeSets, err
+	cnrNodes, _, err := c.cfgObject.containerNodesBuilder.getForEpoch(cnr, epoch)
+	return cnrNodes.nodeSets, err
 }
 
 // IsLocalPublicKey implements [searchsvc.Node], [getsvc.Node].
@@ -640,60 +623,40 @@ func (c *cfg) IsLocalPublicKey(bPubKey []byte) bool {
 //
 // GetObjectNodesAtEpoch implements [getsvc.Node].
 func (c *cfg) GetObjectNodesAtEpoch(addr oid.Address, epoch uint64) ([][]netmapsdk.NodeInfo, []uint32, error) {
-	nodeLists, storagePolicy, networkMap, err := c.getContainerNodesAtEpoch(addr.Container(), epoch)
+	cnrNodes, err := c.cfgObject.containerNodesBuilder.getForObjectAtEpoch(addr, epoch)
 	if err != nil {
 		return nil, nil, err
 	}
 
-	nodeLists, err = networkMap.PlacementVectors(nodeLists, addr.Object())
-	if err != nil {
-		return nil, nil, fmt.Errorf("apply object's storage policy to the network map: %w", err)
-	}
-
-	primaryNums := make([]uint32, storagePolicy.NumberOfReplicas())
-	for i := range primaryNums {
-		primaryNums[i] = storagePolicy.ReplicaNumberByIndex(i)
-	}
-
-	return nodeLists, primaryNums, nil
+	return cnrNodes.nodeSets, cnrNodes.primaryNodesNums, nil
 }
 
 // TODO: docs
 func (c *cfg) ObjectStoragePolicyForContainer(cnrID cid.ID) (putsvc.ObjectStoragePolicy, error) {
-	networkMap, err := netmap.GetLatestNetworkMap(c.netMapSource)
-	if err != nil {
-		return nil, fmt.Errorf("read current network map: %w", err)
-	}
-
-	nodeSets, storagePolicy, err := c.getContainerNodesFromNetworkMap(networkMap, cnrID)
+	cnrNodes, networkMap, cache, err := c.cfgObject.containerNodesBuilder._getForEpoch(cnrID, 0)
 	if err != nil {
-		return nil, fmt.Errorf("get storage nodes for the container in the current network map: %w", err)
-	}
-
-	primaryNodeNums := make([]uint32, storagePolicy.NumberOfReplicas())
-	for i := range primaryNodeNums {
-		primaryNodeNums[i] = storagePolicy.ReplicaNumberByIndex(i)
+		return nil, err
 	}
 
-	return containerStoragePolicy{
-		networkMap:      networkMap,
-		nodeSets:        nodeSets,
-		primaryNodeNums: primaryNodeNums,
+	return &containerStoragePolicy{
+		networkMap: networkMap,
+		cnrNodes:   cnrNodes,
+		cache:      cache,
 	}, nil
 }
 
 type containerStoragePolicy struct {
-	networkMap      *netmapsdk.NetMap
-	nodeSets        [][]netmapsdk.NodeInfo
-	primaryNodeNums []uint32
+	networkMap *netmapsdk.NetMap
+	cnrNodes   containerNodes
+	cache      *containerNodesCacheItem
 }
 
 // TODO: docs
-func (x containerStoragePolicy) StorageNodesForObject(obj oid.ID) ([][]netmapsdk.NodeInfo, []uint32, error) {
-	nodeLists, err := x.networkMap.PlacementVectors(x.nodeSets, obj)
+func (x *containerStoragePolicy) StorageNodesForObject(obj oid.ID) ([][]netmapsdk.NodeInfo, []uint32, error) {
+	nodeLists, err := sortContainerNodesForObjectAtEpoch(x.cnrNodes.nodeSets, x.networkMap, x.cache, obj)
 	if err != nil {
-		return nil, nil, fmt.Errorf("sort container nodes for the object: %w", err)
+		return nil, nil, err
 	}
 
-	return nodeLists, x.primaryNodeNums, nil
+	return nodeLists, x.cnrNodes.primaryNodesNums, nil
 }