Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename morph config to fschain #3021

Closed
roman-khimov opened this issue Nov 20, 2024 · 0 comments · Fixed by #3028
Closed

Rename morph config to fschain #3021

roman-khimov opened this issue Nov 20, 2024 · 0 comments · Fixed by #3028
Assignees
Labels
config Configuration format update or breaking change enhancement Improving existing functionality I3 Minimal impact neofs-ir Inner Ring node application issues neofs-storage Storage node application issues S3 Minimally significant U4 Nothing urgent
Milestone

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when people ask me what "morph" means in the node configuration. We need to discontinue this term, all of the current documentation uses "FS chain" and neo-exporter uses "fschain" for a similar configuration.

Describe the solution you'd like

Rename morph to fschain. With a transition period for a single release where we would accept both (and warn about morph use). Functionally it stays the same with the same inner options.

Additional context

#2702
nspcc-dev/neofs-spec#99
nspcc-dev/neofs-api#310
nspcc-dev/neofs-contract#447

@roman-khimov roman-khimov added enhancement Improving existing functionality neofs-ir Inner Ring node application issues neofs-storage Storage node application issues U4 Nothing urgent config Configuration format update or breaking change S3 Minimally significant I3 Minimal impact labels Nov 20, 2024
@roman-khimov roman-khimov added this to the v0.44.0 milestone Nov 20, 2024
End-rey added a commit that referenced this issue Nov 25, 2024
Rename the `morph` section in the code, config and examples to `fschain`.
Maintain compatibility for the transition and warn if `morph` is used.

Refs #3021.

Signed-off-by: Andrey Butusov <[email protected]>
End-rey added a commit that referenced this issue Nov 25, 2024
Rename the `morph` section in the code, config and examples to `fschain`.
Maintain compatibility for the transition and warn if `morph` is used.

Closes #3021.

Signed-off-by: Andrey Butusov <[email protected]>
End-rey added a commit that referenced this issue Nov 25, 2024
Rename the `morph` section in the code, config and examples to `fschain`.
Maintain compatibility for the transition and warn if `morph` is used.

Refs #3021.

Signed-off-by: Andrey Butusov <[email protected]>
End-rey added a commit that referenced this issue Nov 25, 2024
Rename the `morph` section in the code, config and examples to `fschain`.
Maintain compatibility for the transition and warn if `morph` is used.

Closes #3021.

Signed-off-by: Andrey Butusov <[email protected]>
End-rey added a commit that referenced this issue Nov 25, 2024
Rename the `morph` section in the code, config and examples to `fschain`.
Maintain compatibility for the transition and warn if `morph` is used.

Refs #3021.

Signed-off-by: Andrey Butusov <[email protected]>
End-rey added a commit that referenced this issue Nov 25, 2024
Rename the `morph` section in the code, config and examples to `fschain`.
Maintain compatibility for the transition and warn if `morph` is used.

Closes #3021.

Signed-off-by: Andrey Butusov <[email protected]>
End-rey added a commit that referenced this issue Nov 26, 2024
Rename the `morph` section in the code, config and examples to `fschain`.
Maintain compatibility for the transition and warn if `morph` is used.
Migrate data for deprecated DB key to new.

Refs #3021.

Signed-off-by: Andrey Butusov <[email protected]>
End-rey added a commit that referenced this issue Nov 26, 2024
Rename the `morph` section in the code, config and examples to `fschain`.
Maintain compatibility for the transition and warn if `morph` is used.
Migrate data for deprecated DB key to new.

Closes #3021.

Signed-off-by: Andrey Butusov <[email protected]>
End-rey added a commit that referenced this issue Nov 26, 2024
Rename the `morph` section in the code, config and examples to `fschain`.
Maintain compatibility for the transition and warn if `morph` is used.
Migrate data for deprecated DB key to new.

Refs #3021.

Signed-off-by: Andrey Butusov <[email protected]>
End-rey added a commit that referenced this issue Nov 26, 2024
Rename the `morph` section in the code, config and examples to `fschain`.
Maintain compatibility for the transition and warn if `morph` is used.
Migrate data for deprecated DB key to new.

Closes #3021.

Signed-off-by: Andrey Butusov <[email protected]>
carpawell added a commit that referenced this issue Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Configuration format update or breaking change enhancement Improving existing functionality I3 Minimal impact neofs-ir Inner Ring node application issues neofs-storage Storage node application issues S3 Minimally significant U4 Nothing urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants