Delete objects from wc after flushing #3169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
Drop files from write cache when they're moved to the lower layer storage. Also drop code about `LRUCache` because it is not needed now, since the objects themselves are deleted after flushing. Closes #3077. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
force-pushed
the
3077-fix-write-cache-flushing-loop-to-drop-objects
branch
from
c443373 to
631e099
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3169 +/- ##
==========================================
+ Coverage 23.01% 23.03% +0.01%
==========================================
Files 756 756
Lines 60211 60168 -43
==========================================
Hits 13858 13858
+ Misses 45359 45316 -43
Partials 994 994 ☔ View full report in Codecov by Sentry. |
| "github.com/nspcc-dev/neofs-node/pkg/util" | ||
| apistatus "github.com/nspcc-dev/neofs-sdk-go/client/status" | ||
| oid "github.com/nspcc-dev/neofs-sdk-go/object/id" | ||
| "go.uber.org/zap" | ||
| ) | ||
|
|
||
| // store represents persistent storage with in-memory LRU cache |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3077.
IIUC, the LRU cache was needed since the boltDB was processed in parallel and it was not safe to delete objects directly from there, but now only fstree and therefore it is no longer needed?