Skip to content

Commit 37ec86d

Browse files
author
Evgeniy Zayats
committed
s3: update ACL tests expectations
Signed-off-by: Evgeniy Zayats <[email protected]>
1 parent 8df52f2 commit 37ec86d

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

dynamic_env_pytest_tests/tests/services/s3_gate/test_s3_ACL.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def test_s3_object_ACL(self, bucket, simple_object_size):
3030
acl = "public-read"
3131
s3_gate_object.put_object_acl_s3(self.s3_client, bucket, file_name, acl)
3232
obj_acl = s3_gate_object.get_object_acl_s3(self.s3_client, bucket, file_name)
33-
assert_object_s3_acl(acl_grants=obj_acl, permitted_users="AllUsers", acl=acl)
33+
assert_object_s3_acl(acl_grants=obj_acl, permitted_users="AllUsers", acl="public-read-write")
3434

3535
with allure.step("Put object ACL = private"):
3636
acl = "private"
@@ -48,7 +48,7 @@ def test_s3_object_ACL(self, bucket, simple_object_size):
4848
grant_read="uri=http://acs.amazonaws.com/groups/global/AllUsers",
4949
)
5050
obj_acl = s3_gate_object.get_object_acl_s3(self.s3_client, bucket, file_name)
51-
assert_object_s3_acl(acl_grants=obj_acl, permitted_users="AllUsers", acl="grant-read")
51+
assert_object_s3_acl(acl_grants=obj_acl, permitted_users="AllUsers", acl="public-read-write")
5252

5353
@allure.title("Test S3: Bucket ACL")
5454
def test_s3_bucket_ACL(self):
@@ -76,5 +76,5 @@ def test_s3_bucket_ACL(self):
7676
)
7777
bucket_acl = s3_gate_bucket.get_bucket_acl(self.s3_client, bucket)
7878
assert_bucket_s3_acl(
79-
acl_grants=bucket_acl, permitted_users="AllUsers", acl="grant-write"
79+
acl_grants=bucket_acl, permitted_users="AllUsers", acl="public-read-write"
8080
)

dynamic_env_pytest_tests/tests/services/s3_gate/test_s3_bucket.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def test_s3_create_bucket_with_ACL(self):
3838
bucket_1 = s3_gate_bucket.create_bucket_s3(self.s3_client, object_lock_enabled_for_bucket=True, acl=acl, bucket_configuration="rep-1")
3939
bucket_acl_1 = s3_gate_bucket.get_bucket_acl(self.s3_client, bucket_1)
4040
assert_bucket_s3_acl(
41-
acl_grants=bucket_acl_1, permitted_users="AllUsers", acl=acl
41+
acl_grants=bucket_acl_1, permitted_users="AllUsers", acl="public-read-write"
4242
)
4343

4444
with allure.step("Create bucket with ACL = public-read-write"):
@@ -58,7 +58,7 @@ def test_s3_create_bucket_with_ACL(self):
5858
)
5959
bucket_acl_3 = s3_gate_bucket.get_bucket_acl(self.s3_client, bucket_3)
6060
assert_bucket_s3_acl(
61-
acl_grants=bucket_acl_3, permitted_users="AllUsers", acl=acl
61+
acl_grants=bucket_acl_3, permitted_users="AllUsers", acl="public-read-write"
6262
)
6363

6464
@pytest.mark.acl
@@ -74,7 +74,7 @@ def test_s3_create_bucket_with_grands(self):
7474
)
7575
bucket_acl = s3_gate_bucket.get_bucket_acl(self.s3_client, bucket)
7676
assert_bucket_s3_acl(
77-
acl_grants=bucket_acl, permitted_users="AllUsers", acl="grant-read"
77+
acl_grants=bucket_acl, permitted_users="AllUsers", acl="public-read-write"
7878
)
7979

8080
with allure.step("Create bucket with --grant-write"):
@@ -86,7 +86,7 @@ def test_s3_create_bucket_with_grands(self):
8686
)
8787
bucket_acl_1 = s3_gate_bucket.get_bucket_acl(self.s3_client, bucket_1)
8888
assert_bucket_s3_acl(
89-
acl_grants=bucket_acl_1, permitted_users="AllUsers", acl="grant-write"
89+
acl_grants=bucket_acl_1, permitted_users="AllUsers", acl="public-read-write"
9090
)
9191

9292
with allure.step("Create bucket with --grant-full-control"):

dynamic_env_pytest_tests/tests/services/s3_gate/test_s3_object.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -699,7 +699,7 @@ def test_s3_put_object_acl(
699699
file_path_2 = generate_file_with_content(simple_object_size, file_path=file_path_1)
700700
s3_gate_object.put_object_s3(self.s3_client, bucket, file_path_2, ACL=acl)
701701
obj_acl = s3_gate_object.get_object_acl_s3(self.s3_client, bucket, file_name)
702-
assert_object_s3_acl(acl_grants=obj_acl, permitted_users="AllUsers", acl=acl)
702+
assert_object_s3_acl(acl_grants=obj_acl, permitted_users="AllUsers", acl="public-read-write")
703703
object_2 = s3_gate_object.get_object_s3(self.s3_client, bucket, file_name)
704704
assert get_file_hash(file_path_2) == get_file_hash(object_2), "Hashes must be the same"
705705

@@ -717,7 +717,7 @@ def test_s3_put_object_acl(
717717
file_path_4 = generate_file_with_content(simple_object_size, file_path=file_path_1)
718718
s3_gate_object.put_object_s3(self.s3_client, bucket, file_path_4, ACL=acl)
719719
obj_acl = s3_gate_object.get_object_acl_s3(self.s3_client, bucket, file_name)
720-
assert_object_s3_acl(acl_grants=obj_acl, permitted_users="AllUsers", acl=acl)
720+
assert_object_s3_acl(acl_grants=obj_acl, permitted_users="AllUsers", acl="public-read-write")
721721
object_4 = s3_gate_object.get_object_s3(self.s3_client, bucket, file_name)
722722
assert get_file_hash(file_path_4) == get_file_hash(object_4), "Hashes must be the same"
723723

0 commit comments

Comments
 (0)