replace deprecated unique_together / index_together, fixes #530

Author: ThomasWaldmann

src/nsupdate/main/migrations/0014_replace_deprecated_together_options.py

@@ -0,0 +1,37 @@
+# Generated by Junie to replace deprecated unique_together and index_together
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("main", "0013_alter_host_update_secret"),
+    ]
+
+    operations = [
+        # Remove deprecated Meta options
+        migrations.AlterUniqueTogether(
+            name="host",
+            unique_together=set(),
+        ),
+        migrations.AlterIndexTogether(
+            name="host",
+            index_together=set(),
+        ),
+        migrations.AlterUniqueTogether(
+            name="relatedhost",
+            unique_together=set(),
+        ),
+        # Add explicit constraints
+        migrations.AddConstraint(
+            model_name="host",
+            constraint=models.UniqueConstraint(
+                fields=("name", "domain"), name="unique_host_domain"
+            ),
+        ),
+        migrations.AddConstraint(
+            model_name="relatedhost",
+            constraint=models.UniqueConstraint(
+                fields=("name", "main_host"), name="unique_relatedhost_name_mainhost"
+            ),
+        ),
+    ]

src/nsupdate/main/models.py

@@ -258,13 +258,9 @@ def __str__(self):
         return u"%s.%s" % (self.name, self.domain.name)
 
     class Meta(object):
-        # deprecated, but works:
-        unique_together = (('name', 'domain'),)
-        index_together = (('name', 'domain'),)
-        # this seems to be the new way, but it does not work:
-        # ValueError: Found wrong number (2) of indexes for main_host(name, domain_id).
-        # constraints = [models.constraints.UniqueConstraint(fields=['name', 'domain'], name='unique_host_domain')]
-        # indexes = [models.Index(fields=['name', 'domain'])]
+        constraints = [
+            models.UniqueConstraint(fields=['name', 'domain'], name='unique_host_domain'),
+        ]
         verbose_name = _('host')
         verbose_name_plural = _('hosts')
         ordering = ('domain', 'name')  # groupby domain and sort by name
@@ -421,7 +417,9 @@ def __str__(self):
         return u"%s.%s" % (self.name, str(self.main_host))
 
     class Meta(object):
-        unique_together = (('name', 'main_host'),)
+        constraints = [
+            models.UniqueConstraint(fields=['name', 'main_host'], name='unique_relatedhost_name_mainhost'),
+        ]
         verbose_name = _('related host')
         verbose_name_plural = _('related hosts')
         ordering = ('main_host', 'name')