Skip to content

Commit 6ea0cd0

Browse files
evilpient1m
authored andcommitted
Create reusable getSubscribeURL function
1 parent 60e9dff commit 6ea0cd0

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

background/background.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,11 @@ chrome.tabs.onRemoved.addListener(function(tabId) {
224224
delete feedData[tabId];
225225
});
226226

227+
function getSubscribeURL(feedUrl) {
228+
const url = chrome.extension.getURL("pages/subscribe/subscribe.html");
229+
return url + "?" + encodeURIComponent(feedUrl);
230+
}
231+
227232
chrome.webRequest.onHeadersReceived.addListener(details => {
228233
const header = details.responseHeaders.find(header => {
229234
return header.name.toLowerCase() == "content-type";
@@ -235,10 +240,8 @@ chrome.webRequest.onHeadersReceived.addListener(details => {
235240
// Atom or RSS MIME type, redirect to preview page
236241
const type = header.value.toLowerCase().replace(/^\s+|\s*(?:;.*)?$/g, "");
237242
if (type == "application/rss+xml" || type == "application/atom+xml") {
238-
const url = chrome.extension.getURL("pages/subscribe/subscribe.html") + "?" +
239-
encodeURIComponent(details.url);
240243
return {
241-
redirectUrl: url,
244+
redirectUrl: getSubscribeURL(details.url),
242245
};
243246
}
244247

@@ -260,8 +263,7 @@ chrome.webRequest.onHeadersReceived.addListener(details => {
260263
let feed = await FeedParser.getFeed(details.url);
261264
if (feed.items.length > 0) {
262265
chrome.tabs.update(details.tabId, {
263-
url: chrome.extension.getURL("pages/subscribe/subscribe.html") + "?" +
264-
encodeURIComponent(details.url),
266+
url: getSubscribeURL(details.url),
265267
loadReplace: true
266268
});
267269
}

0 commit comments

Comments
 (0)