Skip to content

Commit 96867b7

Browse files
committed
PDF file sets should not have a pyramid location
1 parent eebdcc3 commit 96867b7

File tree

2 files changed

+36
-0
lines changed

2 files changed

+36
-0
lines changed

Diff for: app/lib/meadow/data/file_sets.ex

+3
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,9 @@ defmodule Meadow.Data.FileSets do
300300
def pyramid_uri_for(%FileSet{core_metadata: %{mime_type: "audio/" <> _thing}}),
301301
do: nil
302302

303+
def pyramid_uri_for(%FileSet{core_metadata: %{mime_type: "application/pdf"}}),
304+
do: nil
305+
303306
def pyramid_uri_for(%FileSet{} = file_set), do: pyramid_uri_for(file_set.id)
304307

305308
def pyramid_uri_for(file_set_id) do

Diff for: app/test/meadow/data/preservation_check_writer_test.exs

+33
Original file line numberDiff line numberDiff line change
@@ -232,4 +232,37 @@ defmodule Meadow.Data.PreservationCheckWriterTest do
232232
PreservationCheckWriter.generate_report(@report_filename)
233233
end
234234
end
235+
236+
describe "generate_report/1 with pdf (X) files" do
237+
setup do
238+
video_work = work_fixture(%{work_type: %{id: "VIDEO", scheme: "work_type"}})
239+
240+
video_access_file_set =
241+
file_set_fixture(%{
242+
work_id: video_work.id,
243+
accession_number: "101113",
244+
role: %{id: "X", scheme: "FILE_SET_ROLE"},
245+
core_metadata: %{
246+
digests: %{
247+
"sha256" => @sha256,
248+
"sha1" => @sha1,
249+
"md5" => @md5
250+
},
251+
location: "s3://#{@preservation_bucket}/#{Pairtree.preservation_path(@sha256)}",
252+
mime_type: "application/pdf",
253+
original_filename: "test.pdf"
254+
}
255+
})
256+
257+
{:ok, file_set: pdf_aux_file_set}
258+
end
259+
260+
@describetag s3: [@preservation_fixture]
261+
test "does not record an error if pdf aux file set pyramids are missing", %{
262+
file_set: _file_set
263+
} do
264+
assert {:ok, "s3://#{@preservation_check_bucket}/pres_check.csv", 0} =
265+
PreservationCheckWriter.generate_report(@report_filename)
266+
end
267+
end
235268
end

0 commit comments

Comments
 (0)