Skip to content

Commit fea792b

Browse files
kohlisidyhl25
andauthored
fix: set max decode size of proto message (#2275)
Signed-off-by: Yashash H L <[email protected]> Co-authored-by: Yashash H L <[email protected]>
1 parent 346f2a7 commit fea792b

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

rust/numaflow-core/src/monovertex.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ pub(crate) async fn start_forwarder(
5959
let mut source_grpc_client =
6060
SourceClient::new(create_rpc_channel(source_config.socket_path.clone().into()).await?)
6161
.max_encoding_message_size(source_config.grpc_max_message_size)
62-
.max_encoding_message_size(source_config.grpc_max_message_size);
62+
.max_decoding_message_size(source_config.grpc_max_message_size);
6363

6464
wait_until_source_ready(&cln_token, &mut source_grpc_client).await?;
6565
Some(source_grpc_client)
@@ -92,7 +92,7 @@ pub(crate) async fn start_forwarder(
9292
let mut sink_grpc_client =
9393
SinkClient::new(create_rpc_channel(udsink_config.socket_path.clone().into()).await?)
9494
.max_encoding_message_size(udsink_config.grpc_max_message_size)
95-
.max_encoding_message_size(udsink_config.grpc_max_message_size);
95+
.max_decoding_message_size(udsink_config.grpc_max_message_size);
9696

9797
wait_until_sink_ready(&cln_token, &mut sink_grpc_client).await?;
9898
Some(sink_grpc_client)
@@ -125,7 +125,7 @@ pub(crate) async fn start_forwarder(
125125
create_rpc_channel(fb_sink_config.socket_path.clone().into()).await?,
126126
)
127127
.max_encoding_message_size(fb_sink_config.grpc_max_message_size)
128-
.max_encoding_message_size(fb_sink_config.grpc_max_message_size);
128+
.max_decoding_message_size(fb_sink_config.grpc_max_message_size);
129129

130130
wait_until_sink_ready(&cln_token, &mut fb_sink_grpc_client).await?;
131131
Some(fb_sink_grpc_client)
@@ -164,7 +164,7 @@ pub(crate) async fn start_forwarder(
164164
create_rpc_channel(transformer_config.socket_path.clone().into()).await?,
165165
)
166166
.max_encoding_message_size(transformer_config.grpc_max_message_size)
167-
.max_encoding_message_size(transformer_config.grpc_max_message_size);
167+
.max_decoding_message_size(transformer_config.grpc_max_message_size);
168168

169169
wait_until_transformer_ready(&cln_token, &mut transformer_grpc_client).await?;
170170
Some(transformer_grpc_client.clone())

rust/numaflow-core/src/pipeline.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ async fn create_source_type(
244244
create_rpc_channel(udsource_config.socket_path.clone().into()).await?,
245245
)
246246
.max_encoding_message_size(udsource_config.grpc_max_message_size)
247-
.max_encoding_message_size(udsource_config.grpc_max_message_size);
247+
.max_decoding_message_size(udsource_config.grpc_max_message_size);
248248
wait_until_source_ready(&cln_token, &mut source_grpc_client).await?;
249249
let (ud_read, ud_ack, ud_lag) = new_source(
250250
source_grpc_client.clone(),
@@ -279,7 +279,7 @@ async fn create_transformer(
279279
create_rpc_channel(ud_transformer.socket_path.clone().into()).await?,
280280
)
281281
.max_encoding_message_size(ud_transformer.grpc_max_message_size)
282-
.max_encoding_message_size(ud_transformer.grpc_max_message_size);
282+
.max_decoding_message_size(ud_transformer.grpc_max_message_size);
283283
wait_until_transformer_ready(&cln_token, &mut transformer_grpc_client).await?;
284284
return Ok((
285285
Some(SourceTransformHandle::new(transformer_grpc_client.clone()).await?),

rust/numaflow-core/src/shared/utils.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ pub(crate) async fn create_sink_handle(
191191
let mut sink_grpc_client =
192192
SinkClient::new(create_rpc_channel(ud_config.socket_path.clone().into()).await?)
193193
.max_encoding_message_size(ud_config.grpc_max_message_size)
194-
.max_encoding_message_size(ud_config.grpc_max_message_size);
194+
.max_decoding_message_size(ud_config.grpc_max_message_size);
195195
wait_until_sink_ready(cln_token, &mut sink_grpc_client).await?;
196196
// TODO: server info?
197197

0 commit comments

Comments
 (0)