Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event tap should treat suppression of key events as a subscription. #109

Closed
numist opened this issue Oct 7, 2014 · 1 comment
Closed
Milestone

Comments

@numist
Copy link
Owner

numist commented Oct 7, 2014

@property (nonatomic, assign, readwrite) BOOL suppressKeyEvents;
should be
- (void)observer:(id)observer wantsSuppressKeyEvents:(_Bool)suppressKeyEvents;

Using a boolean for this seemed like a good idea at the time, but if two actors ever want to suppress key events they'll clobber each other. A subscription model with the event tap managing the actual binary state of suppression is a better approach.

@numist numist added this to the Future milestone Oct 7, 2014
@numist
Copy link
Owner Author

numist commented Apr 13, 2021

Fixed in #139

@numist numist closed this as completed Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant