Swift/SwiftUI rewrite #139
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt, AX permissions are still screwy as heck
Keeping all those ugly force casts together in one place
…owInfo] from the results of CGWindowListCopyWindowInfo()
…dowInfo Relevant keys in the info dictionary populated by AX
This was referenced Apr 13, 2021
|
Oh GitHub supports linked issues now. Well, now I know that for next time I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this branch has been coming along for a while, and the results are already quite pleasant:
It's faster, it's less buggy. The swiftifacation of Switch's use of event taps in particular exposed some likely issues in the [Objective-]C implementation while also making it easier to manage adding a bonus runloop dedicated to servicing the event tap(s) at a higher priority than the main thread itself.
The downsides so far are the obvious: tests need to be ported to the new world order (and there's a lot of them since window groups aren't exposed as API so Switch has to maintain a laundry list of compatibility hacks for "quirks") and SwiftUI doesn't play great with AppKit stuff like mouse interactions. Oh yeah, and window switching via Accessibility got completely broken by Big Sur and now you get all of the app's windows instead of just the one you selected. Sigh.
But it's far enough along that it's ready for people familiar with git and Xcode to try out. Remaining work toward 0.0.10β parity includes: