🐛 Don't swallow stderr output (#269)

hauntsaninja · web-flow · commit 189db80c3584 · 2025-03-07T11:23:29.000+01:00
cc @jorenham I was looking into python/mypy#18756 (comment) It looks like the pre-release version of mypy crashes (for some reason related to property changes, will investigate). Crash logs are emitted to stderr and process exits with exit code 2. This code does correctly chain the exit code, but swallows stderr.
diff --git a/tool/stubtest.py b/tool/stubtest.py
@@ -128,6 +128,7 @@ def main() -> int:
         capture_output=True,
         env={"FORCE_COLOR": "1"} | os.environ,
     )
+    sys.stderr.buffer.write(result.stderr)
     output = _rewrite_mypy_output(result.stdout)
     sys.stdout.buffer.write(output)
     sys.stdout.buffer.flush()

Original file line number	Diff line number	Diff line change
`@@ -128,6 +128,7 @@ def main() -> int:`
`128`	`128`	`capture_output=True,`
`129`	`129`	`env={"FORCE_COLOR": "1"} \| os.environ,`
`130`	`130`	`)`
	`131`	`+ sys.stderr.buffer.write(result.stderr)`
`131`	`132`	`output = _rewrite_mypy_output(result.stdout)`
`132`	`133`	`sys.stdout.buffer.write(output)`
`133`	`134`	`sys.stdout.buffer.flush()`