Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid image causes application to show ... #3159

Open
nus-pe-bot opened this issue Apr 16, 2021 · 1 comment
Open

Invalid image causes application to show ... #3159

nus-pe-bot opened this issue Apr 16, 2021 · 1 comment

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Apr 16, 2021

When any non-image file is used as a profile image, the following can be observed.

image.png

The following screen should have been shown instead, perhaps with a different text underneath:

image.png

Making the application fullscreen does however show the filename, but there is no error message presented to the user.

image.png


[original: nus-cs2103-AY2021S2/pe-interim#3159] [original labels: severity.Low type.FunctionalityBug]
@Tomashiwa
Copy link
Contributor

Team's Response

Cannot be reproduced with non-image file. For example, we use the command edit 1 i/john_doe.txt, the application will feedback the user that the file is non-image and the profile picture will not be updated.
image.png

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants