Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use nu as code block lang #1807

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

Kissaki
Copy link
Contributor

@Kissaki Kissaki commented Feb 14, 2025

CONTRIBUTING.md defines a preference of nu over nushell, which overwhelmingly matches our code blocks.

These 66 occurrences were the outliers.

CONTRIBUTING.md defines a preference of `nu` over `nushell`, which overwhelmingly matches our code blocks.

These 66 occurrences were the outliers.
@fdncred
Copy link
Collaborator

fdncred commented Feb 14, 2025

I think the difference may be that github only recognizes nushell whereas our documentation recognizes nu. Thanks.

@fdncred fdncred merged commit 0b47025 into nushell:main Feb 14, 2025
2 checks passed
@Kissaki
Copy link
Contributor Author

Kissaki commented Feb 15, 2025

I wasn't aware that GitHub recognizes nushell; interesting.

I was thinking of the difference between nu as the programming language and interactive REPL examples as well, and whether - if both are supported - it would be worth it to distinguish between the two.

Either way, currently, the docs only use nu. Would be nice if GitHub were to support that too.

@NotTheDr01ds
Copy link
Contributor

@Kissaki thanks for the cleanup/consistency here. Greatly appreciated!

The GitHub problem is apparently that nu is already assigned to an earlier, unrelated language.

In VuePress, we can configure it to use our syntax, but we can't change that on GitHub, I don't believe?

I spent far too long using nu on GitHub and not understanding why it wasn't highlighting properly :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants