Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup.md): Quote the EDITOR value #1815

Merged
merged 1 commit into from
Feb 22, 2025
Merged

fix(setup.md): Quote the EDITOR value #1815

merged 1 commit into from
Feb 22, 2025

Conversation

choan
Copy link
Contributor

@choan choan commented Feb 22, 2025

help: the parsing of assignments was changed in 0.97.0, and this would have previously been treated as a string.

Alternatively, quote the string with single or double
quotes to avoid it being interpreted as a command name. This restriction may be removed in a future release.

help: the parsing of assignments was changed in 0.97.0, and this would have previously been treated as a string. 

Alternatively, quote the string with single or double
        quotes to avoid it being interpreted as a command name. This restriction may be removed in a future release.
Copy link
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, we forgot that here. Thanks!

@fdncred
Copy link
Collaborator

fdncred commented Feb 22, 2025

Thanks!

Related/Unrelated, in the nushell config you can have parameters. I'm not sure if that works with env vars though.

$env.config.buffer_editor = ["emacsclient", "-s", "light", "-t"]

@fdncred fdncred merged commit 6b20574 into nushell:main Feb 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants