Skip to content
This repository was archived by the owner on Feb 14, 2022. It is now read-only.

Commit 5204b9f

Browse files
author
Simon Hofmann
committed
Reverted installation
1 parent d770635 commit 5204b9f

13 files changed

+14
-225
lines changed

Diff for: build/dirs.d.ts

-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
export declare const dirs: {
22
rootDir: string;
33
opencvRoot: string;
4-
opencvInstallRoot: string;
54
opencvSrc: string;
65
opencvContribSrc: string;
76
opencvContribModules: string;

Diff for: build/dirs.js

+4-13
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
Object.defineProperty(exports, "__esModule", { value: true });
33
var path = require("path");
44
var utils_1 = require("./utils");
5-
var env_1 = require("./env");
6-
var os_1 = require("os");
75
var rootDir = path.resolve(__dirname, '../');
86
var opencvRoot = path.join(rootDir, 'opencv');
97
var opencvSrc = path.join(opencvRoot, 'opencv');
@@ -14,22 +12,15 @@ var opencvInclude = path.join(opencvBuild, 'include');
1412
var opencvLibDir = utils_1.isWin() ? path.join(opencvBuild, 'lib/Release') : path.join(opencvBuild, 'lib');
1513
var opencvBinDir = utils_1.isWin() ? path.join(opencvBuild, 'bin/Release') : path.join(opencvBuild, 'bin');
1614
var autoBuildFile = path.join(opencvRoot, 'auto-build.json');
17-
var installDir = os_1.homedir();
18-
var installedOpenCV = path.resolve(path.join(installDir, 'opencv-prebuilt'));
19-
var installedOpencvBuild = path.join(installedOpenCV, 'build');
20-
var installedOpencvInclude = path.join(installedOpencvBuild, 'include');
21-
var installedOpencvLibDir = utils_1.isWin() ? path.join(installedOpencvBuild, 'lib/Release') : path.join(installedOpencvBuild, 'lib');
22-
var installedOpencvBinDir = utils_1.isWin() ? path.join(installedOpencvBuild, 'bin/Release') : path.join(installedOpencvBuild, 'bin');
2315
exports.dirs = {
2416
rootDir: rootDir,
2517
opencvRoot: opencvRoot,
26-
opencvInstallRoot: installedOpenCV,
2718
opencvSrc: opencvSrc,
2819
opencvContribSrc: opencvContribSrc,
2920
opencvContribModules: opencvContribModules,
30-
opencvBuild: env_1.isAutoBuildEnabled() ? opencvBuild : installedOpencvBuild,
31-
opencvInclude: env_1.isAutoBuildEnabled() ? opencvInclude : installedOpencvInclude,
32-
opencvLibDir: env_1.isAutoBuildEnabled() ? opencvLibDir : installedOpencvLibDir,
33-
opencvBinDir: env_1.isAutoBuildEnabled() ? opencvBinDir : installedOpencvBinDir,
21+
opencvBuild: opencvBuild,
22+
opencvInclude: opencvInclude,
23+
opencvLibDir: opencvLibDir,
24+
opencvBinDir: opencvBinDir,
3425
autoBuildFile: autoBuildFile
3526
};

Diff for: build/index.d.ts

-1
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,4 @@ export declare const opencvInclude: string;
44
export declare const opencvLibDir: string;
55
export declare const opencvBinDir: string;
66
export declare const opencvBuildDir: string;
7-
export declare const installedOpenCV: string;
87
export declare const getLibs: (libDir: string) => import("./types").OpencvModule[];

Diff for: build/index.js

-1
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,4 @@ exports.opencvInclude = dirs_1.dirs.opencvInclude;
1515
exports.opencvLibDir = dirs_1.dirs.opencvLibDir;
1616
exports.opencvBinDir = dirs_1.dirs.opencvBinDir;
1717
exports.opencvBuildDir = dirs_1.dirs.opencvBuild;
18-
exports.installedOpenCV = dirs_1.dirs.opencvInstallRoot;
1918
exports.getLibs = getLibsFactory_1.getLibsFactory({ isWin: utils_1.isWin, isOSX: utils_1.isOSX, opencvModules: constants_1.opencvModules, path: path, fs: fs });

Diff for: build/install.js

+2-17
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ var utils_1 = require("./utils");
4141
var log = require("npmlog");
4242
function install() {
4343
return __awaiter(this, void 0, void 0, function () {
44-
var err_1, e_1;
44+
var err_1;
4545
return __generator(this, function (_a) {
4646
switch (_a.label) {
4747
case 0:
@@ -71,22 +71,7 @@ function install() {
7171
log.error(err_1);
7272
process.exit(1);
7373
return [3 /*break*/, 6];
74-
case 6:
75-
if (!!env_1.isInstallDisabled()) return [3 /*break*/, 10];
76-
_a.label = 7;
77-
case 7:
78-
_a.trys.push([7, 9, , 10]);
79-
log.info("Moving files", "");
80-
return [4 /*yield*/, setupOpencv_1.installOpenCV()];
81-
case 8:
82-
_a.sent();
83-
return [3 /*break*/, 10];
84-
case 9:
85-
e_1 = _a.sent();
86-
log.error(e_1);
87-
process.exit(1);
88-
return [3 /*break*/, 10];
89-
case 10: return [2 /*return*/];
74+
case 6: return [2 /*return*/];
9075
}
9176
});
9277
});

Diff for: build/setupOpencv.d.ts

-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1 @@
11
export declare function setupOpencv(): Promise<void>;
2-
export declare function installOpenCV(): Promise<void>;
3-
export declare function writeVersionInfo(version: string): void;
4-
export declare function readVersionInfo(): string | null;
5-
export declare function getPackageVersion(): string;

Diff for: build/setupOpencv.js

-71
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,12 @@ var __generator = (this && this.__generator) || function (thisArg, body) {
3434
if (op[0] & 5) throw op[1]; return { value: op[0] ? op[1] : void 0, done: true };
3535
}
3636
};
37-
var _this = this;
3837
Object.defineProperty(exports, "__esModule", { value: true });
3938
var constants_1 = require("./constants");
4039
var dirs_1 = require("./dirs");
4140
var env_1 = require("./env");
4241
var findMsBuild_1 = require("./findMsBuild");
4342
var utils_1 = require("./utils");
44-
var fs_extra_1 = require("fs-extra");
45-
var fs_1 = require("fs");
46-
var path_1 = require("path");
4743
var log = require('npmlog');
4844
function getIfExistsDirCmd(dirname, exists) {
4945
if (exists === void 0) { exists = true; }
@@ -208,70 +204,3 @@ function setupOpencv() {
208204
});
209205
}
210206
exports.setupOpencv = setupOpencv;
211-
function installOpenCV() {
212-
return __awaiter(this, void 0, void 0, function () {
213-
return __generator(this, function (_a) {
214-
switch (_a.label) {
215-
case 0:
216-
if (!fs_extra_1.existsSync(dirs_1.dirs.opencvInstallRoot)) return [3 /*break*/, 5];
217-
log.info("Directory " + dirs_1.dirs.opencvInstallRoot + " already exists, assuming existing installation.");
218-
if (!(readVersionInfo() === null || readVersionInfo() !== getPackageVersion())) return [3 /*break*/, 3];
219-
log.info("Discovered version missmatch. Have: " + readVersionInfo() + " Want: " + getPackageVersion());
220-
log.info("Removing previous installation.");
221-
return [4 /*yield*/, utils_1.exec(getRmDirCmd(dirs_1.dirs.opencvInstallRoot))];
222-
case 1:
223-
_a.sent();
224-
return [4 /*yield*/, copyOpenCV()];
225-
case 2:
226-
_a.sent();
227-
return [3 /*break*/, 4];
228-
case 3:
229-
log.info("Remove the existing directory to force a clean install.");
230-
_a.label = 4;
231-
case 4: return [3 /*break*/, 7];
232-
case 5:
233-
log.info("Installing to " + dirs_1.dirs.opencvInstallRoot, "");
234-
return [4 /*yield*/, copyOpenCV()];
235-
case 6:
236-
_a.sent();
237-
_a.label = 7;
238-
case 7: return [2 /*return*/];
239-
}
240-
});
241-
});
242-
}
243-
exports.installOpenCV = installOpenCV;
244-
var copyOpenCV = function () { return __awaiter(_this, void 0, void 0, function () {
245-
return __generator(this, function (_a) {
246-
switch (_a.label) {
247-
case 0: return [4 /*yield*/, fs_extra_1.copy(dirs_1.dirs.opencvRoot, dirs_1.dirs.opencvInstallRoot, {
248-
recursive: true,
249-
errorOnExist: true,
250-
overwrite: false
251-
})];
252-
case 1:
253-
_a.sent();
254-
writeVersionInfo(getPackageVersion());
255-
return [2 /*return*/];
256-
}
257-
});
258-
}); };
259-
var getVersionInfoPath = function () { return path_1.join(dirs_1.dirs.opencvInstallRoot, "versioninfo.json"); };
260-
function writeVersionInfo(version) {
261-
fs_1.writeFileSync(getVersionInfoPath(), JSON.stringify({ version: version }));
262-
}
263-
exports.writeVersionInfo = writeVersionInfo;
264-
function readVersionInfo() {
265-
try {
266-
return require(getVersionInfoPath()).version;
267-
}
268-
catch (e) {
269-
return null;
270-
}
271-
}
272-
exports.readVersionInfo = readVersionInfo;
273-
function getPackageVersion() {
274-
var packageJson = require(path_1.join(__dirname, "../package.json"));
275-
return packageJson.name + "@" + packageJson.version;
276-
}
277-
exports.getPackageVersion = getPackageVersion;

Diff for: package-lock.json

+1-38
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nut-tree/opencv-build",
3-
"version": "3.4.6-home",
3+
"version": "3.4.6-local",
44
"description": "A simple script to auto build recent OpenCV + contrib version via npm. Based on [justadudewhohacks/npm-opencv-build](https://github.com/justadudewhohacks/npm-opencv-build)",
55
"main": "./build/index.js",
66
"scripts": {
@@ -26,14 +26,12 @@
2626
},
2727
"homepage": "https://github.com/nut-tree/npm-opencv-build#readme",
2828
"dependencies": {
29-
"fs-extra": "^8.0.1",
3029
"npmlog": "^4.1.2"
3130
},
3231
"devDependencies": {
33-
"@types/fs-extra": "^7.0.0",
3432
"@types/node": "^12.0.0",
3533
"chai": "^4.2.0",
3634
"mocha": "^6.1.4",
3735
"typescript": "^3.4.5"
3836
}
39-
}
37+
}

Diff for: src/dirs.ts

+4-16
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ import * as path from 'path';
22

33
import {isWin} from './utils';
44

5-
import {isAutoBuildEnabled} from "./env";
6-
import {homedir} from "os";
7-
85
const rootDir = path.resolve(__dirname, '../');
96
const opencvRoot = path.join(rootDir, 'opencv');
107
const opencvSrc = path.join(opencvRoot, 'opencv');
@@ -16,24 +13,15 @@ const opencvLibDir = isWin() ? path.join(opencvBuild, 'lib/Release') : path.join
1613
const opencvBinDir = isWin() ? path.join(opencvBuild, 'bin/Release') : path.join(opencvBuild, 'bin');
1714
const autoBuildFile = path.join(opencvRoot, 'auto-build.json');
1815

19-
const installDir = homedir();
20-
const installedOpenCV = path.resolve(path.join(installDir, 'opencv-prebuilt'));
21-
22-
const installedOpencvBuild = path.join(installedOpenCV, 'build');
23-
const installedOpencvInclude = path.join(installedOpencvBuild, 'include');
24-
const installedOpencvLibDir = isWin() ? path.join(installedOpencvBuild, 'lib/Release') : path.join(installedOpencvBuild, 'lib');
25-
const installedOpencvBinDir = isWin() ? path.join(installedOpencvBuild, 'bin/Release') : path.join(installedOpencvBuild, 'bin');
26-
2716
export const dirs = {
2817
rootDir,
2918
opencvRoot,
30-
opencvInstallRoot: installedOpenCV,
3119
opencvSrc,
3220
opencvContribSrc,
3321
opencvContribModules,
34-
opencvBuild: isAutoBuildEnabled() ? opencvBuild : installedOpencvBuild,
35-
opencvInclude: isAutoBuildEnabled() ? opencvInclude : installedOpencvInclude,
36-
opencvLibDir: isAutoBuildEnabled() ? opencvLibDir : installedOpencvLibDir,
37-
opencvBinDir: isAutoBuildEnabled() ? opencvBinDir : installedOpencvBinDir,
22+
opencvBuild,
23+
opencvInclude,
24+
opencvLibDir,
25+
opencvBinDir,
3826
autoBuildFile
3927
};

Diff for: src/index.ts

-1
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,4 @@ export const opencvInclude = dirs.opencvInclude;
1212
export const opencvLibDir = dirs.opencvLibDir;
1313
export const opencvBinDir = dirs.opencvBinDir;
1414
export const opencvBuildDir = dirs.opencvBuild;
15-
export const installedOpenCV = dirs.opencvInstallRoot;
1615
export const getLibs = getLibsFactory({isWin, isOSX, opencvModules, path, fs});

Diff for: src/install.ts

+1-10
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import {autoBuildFlags, isAutoBuildEnabled, isInstallDisabled, isWithoutContrib, opencvVersion} from "./env";
2-
import {installOpenCV, setupOpencv} from "./setupOpencv";
2+
import {setupOpencv} from "./setupOpencv";
33
import {requireCmake, requireGit} from "./utils";
44

55
const log = require("npmlog");
@@ -27,13 +27,4 @@ export async function install() {
2727
process.exit(1);
2828
}
2929
}
30-
if (!isInstallDisabled()) {
31-
try {
32-
log.info("Moving files", "");
33-
await installOpenCV();
34-
} catch (e) {
35-
log.error(e);
36-
process.exit(1);
37-
}
38-
}
3930
}

0 commit comments

Comments
 (0)