chore(lint): adopt shared eslint base config (#675)

* chore(lint): adopt shared eslint base config

Bump eslint-plugin-harlanzw to 0.18.1 and route the copy-pasted override
blocks through harlanzw({ base }). Drops the hand-rolled test relaxation
and examples/package.json catalog exemptions.

* chore(lint): keep the playground linted, bump to 0.19.0

`base({ ignores: false })` hands the ignore set back to this repo, which
lints its playground on purpose. A global ignore cannot be undone by a
later config, so the shared set had dropped 320 files from the run.

File count is back to 702, matching main.

* chore: bump eslint-plugin-harlanzw to 0.19.2

* refactor: take the prefer-satisfies suggestions that typecheck

Eight object literals annotated `Record<string, V>` that are only ever read by a
static key. `satisfies` keeps their keys, so `keyof typeof` and autocomplete work.

Two are left alone, because narrowing them breaks the build:
`emoji-names-minimal.ts` is indexed from another file, and `styleDirectives.ts`
spreads its map into `BREAKPOINTS`, which is then indexed. The rule cannot see
either without type information.

pnpm typecheck clean, 933 unit tests pass.

Author: harlan-zw

eslint.config.js

@@ -1,29 +1,22 @@
 import antfu from '@antfu/eslint-config'
 import harlanzw from 'eslint-plugin-harlanzw'
 
-export default antfu({
-  ignores: ['.claude'],
-  rules: {
-    'node/prefer-global/process': 'off',
-    'node/prefer-global/buffer': 'off',
-    'no-use-before-define': 'off',
+export default antfu(
+  // og-image lints its playground on purpose, so the shared ignore set is off and
+  // this repo keeps its own list. A global ignore cannot be undone downstream.
+  { ignores: ['.claude'] },
+  ...harlanzw({
+    base: { type: 'app', ignores: false },
+    link: true,
+    nuxt: true,
+    vue: true,
+    content: true,
+  }),
+  {
+    rules: {
+      'harlanzw/link-no-underscores': 'off',
+      'harlanzw/link-trailing-slash': 'off',
+      'harlanzw/link-lowercase': 'off',
+    },
   },
-}, ...harlanzw({ link: true, nuxt: true, vue: true, content: true }), {
-  files: ['test/**/*.ts', 'test/**/*.mjs'],
-  rules: {
-    'e18e/prefer-static-regex': 'off',
-  },
-}, {
-  rules: {
-    'harlanzw/link-no-underscores': 'off',
-    'harlanzw/link-trailing-slash': 'off',
-    'harlanzw/link-lowercase': 'off',
-  },
-}, {
-  files: ['examples/**/package.json'],
-  rules: {
-    'pnpm/json-enforce-catalog': 'off',
-    'pnpm/json-valid-catalog': 'off',
-    'pnpm/json-prefer-workspace-settings': 'off',
-  },
-})
+)

pnpm-lock.yaml

@@ -62,6 +62,7 @@ minimumReleaseAgeExclude:
   - '@unhead/vue@3.2.1'
   - unhead@3.2.1
   - satori@0.28.2
+  - eslint-plugin-harlanzw@0.19.2
 shellEmulator: true
 
 trustPolicy: no-downgrade
@@ -135,7 +136,7 @@ catalog:
   defu: ^6.1.7
   devalue: ^5.9.0
   eslint: ^10.8.1
-  eslint-plugin-harlanzw: ^0.17.1
+  eslint-plugin-harlanzw: ^0.19.2
   exsolve: ^1.1.1
   fnv1a-64: ^0.1.2
   fontless: ^0.2.1

pnpm-workspace.yaml

@@ -485,7 +485,7 @@ function buildThemeVars(
     buildNuxtUiVars(vars, nuxtUiColors, theme)
 
   if (extracted) {
-    const themeRootAttrs: Record<string, string> = { 'data-theme': theme }
+    const themeRootAttrs = { 'data-theme': theme } satisfies Record<string, string>
     const themeVars = resolveExtractedVars(extracted, themeRootAttrs)
     for (const [n, v] of themeVars)
       vars.set(n, v)

src/build/css/providers/tw4.ts

@@ -445,7 +445,7 @@ async function removeDeprecatedConfigKeys(rootDir: string, keys: Array<{ key: st
 }
 
 // Deprecated ogImage config keys and their replacements
-const DEPRECATED_CONFIG_KEYS: Record<string, string> = {
+const DEPRECATED_CONFIG_KEYS = {
   fonts: '@nuxt/fonts module (migrated automatically)',
   strictNuxtContentPaths: 'Removed (no effect in Content v3)',
   playground: 'Removed (use Nuxt DevTools)',
@@ -459,7 +459,7 @@ const DEPRECATED_CONFIG_KEYS: Record<string, string> = {
   cacheKey: 'Removed',
   static: 'zeroRuntime',
   componentOptions: 'Removed (use defineOgImage())',
-}
+} satisfies Record<string, string>
 
 // Check if nuxt config has deprecated options
 async function checkNuxtConfig(rootDir: string): Promise<{

src/cli.ts

@@ -21,7 +21,7 @@ import {
   validateProviderSetup,
 } from './utils/dependencies'
 
-const DEPRECATED_CONFIG: Record<string, string> = {
+const DEPRECATED_CONFIG = {
   playground: 'Removed - use Nuxt DevTools',
   host: 'Use site.url or NUXT_SITE_URL',
   siteUrl: 'Use site.url or NUXT_SITE_URL',
@@ -33,7 +33,7 @@ const DEPRECATED_CONFIG: Record<string, string> = {
   cacheKey: 'Removed',
   static: 'Removed - use zeroRuntime',
   fonts: 'Use @nuxt/fonts module instead',
-}
+} satisfies Record<string, string>
 
 const DEPRECATED_COMPOSABLES = [
   'defineOgImageStatic',

src/onboarding.ts

@@ -28,7 +28,7 @@ describe('zeroRuntime', () => {
     await exec('nuxt', ['build'], { nodeOptions: { cwd: fixtureDir } })
     const serverOutputPath = resolve('../fixtures/zero-runtime/.output/server')
     const { stdout } = await exec('du', ['-sh', serverOutputPath])
-    // eslint-disable-next-line no-console,style/no-tabs
+    // eslint-disable-next-line style/no-tabs
     console.log(`Size: ${stdout.split('	')[0]}`)
     const imagePath = resolve('../fixtures/zero-runtime/.output/public/_og')
     const images = await globby('**/*.png', { cwd: imagePath }).then((r: string[]) => r.sort())

test/e2e-not-nuxt/zeroRuntimeBuild.test.ts

@@ -29,7 +29,7 @@ describe('multi-font-families', () => {
       '/font-black-takumi',
     )
 
-    const snapshotIds: Record<string, string> = {
+    const snapshotIds = {
       '/': 'multi-font-lobster',
       '/playfair': 'multi-font-playfair',
       '/roboto': 'multi-font-jetbrains',
@@ -43,7 +43,7 @@ describe('multi-font-families', () => {
       '/biz-udp-bold': 'multi-font-biz-udp-bold-takumi',
       '/font-black': 'multi-font-font-black',
       '/font-black-takumi': 'multi-font-font-black-takumi',
-    }
+    } satisfies Record<string, string>
 
     for (const [path, id] of Object.entries(snapshotIds)) {
       // Use tighter threshold for biz-udp-bold: the font-weight regression

test/e2e/multi-font-families.test.ts

@@ -9,7 +9,7 @@ describe('font-requirements', () => {
   })
 
   describe('font weight class mapping', () => {
-    const FONT_WEIGHT_CLASSES: Record<string, number> = {
+    const FONT_WEIGHT_CLASSES = {
       'font-thin': 100,
       'font-extralight': 200,
       'font-light': 300,
@@ -19,7 +19,7 @@ describe('font-requirements', () => {
       'font-bold': 700,
       'font-extrabold': 800,
       'font-black': 900,
-    }
+    } satisfies Record<string, number>
 
     it('should have correct weight mappings', () => {
       expect(FONT_WEIGHT_CLASSES['font-thin']).toBe(100)

test/unit/font-requirements.test.ts

@@ -82,11 +82,11 @@ describe('extractCustomFontFamilies', () => {
 })
 
 describe('resolveFontFamilies', () => {
-  const fontVars: Record<string, string> = {
+  const fontVars = {
     'font-sans': 'Inter, sans-serif',
     'font-serif': '\'Playfair Display\', Georgia, serif',
     'font-mono': '\'JetBrains Mono\', monospace',
-  }
+  } satisfies Record<string, string>
 
   it('returns empty when no classes or names', () => {
     expect(resolveFontFamilies([], [], fontVars)).toEqual([])