Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence trimming should trim even more when using one core #17780

Open
hozosch opened this issue Mar 6, 2025 · 2 comments
Open

Silence trimming should trim even more when using one core #17780

hozosch opened this issue Mar 6, 2025 · 2 comments

Comments

@hozosch
Copy link

hozosch commented Mar 6, 2025

Is your feature request related to a problem? Please describe.

Silence trimming in conjunction with Wasapi, in my view, is the best thing that's been done in a while. I love how much more responsive things have become, and this is also very noticeable with one core. However, when compared to things such as sapi5 ESpeak, it still isn't as responsive.

Describe the solution you'd like

I suspect that there still isn't enough silence being trimmed with one core. But this is also voice specific, for example, the austrian German voice is nice and responsive. However, other voices are lagging a bit behind. I suspect that there's still silence which could be trimmed, but I don't know how easy it is to be implemented. Nevertheless, I wanted to bring this up for it to be investigated.

Describe alternatives you've considered

We could leave it as is, as the way it is now already has a great impact. That's the only other way I can think of, but responsiveness should be a top priority for a good screen reader.

Additional context

@gexgd0419
Copy link
Contributor

Could you provide some more detail of what voice you think is lagging a bit behind? For example, the name and the language of the voice? If the voice has a SAPI5 version, does the SAPI5 version lag as well?

@hozosch
Copy link
Author

hozosch commented Mar 6, 2025

I think I notice it most with the swiss German voice. It's the only one for that language, and there is no sapi 5 version of it, unless you would do a registry hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants