Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up pyright on pre-commit CI #17794

Open
seanbudd opened this issue Mar 7, 2025 · 0 comments
Open

Fix up pyright on pre-commit CI #17794

seanbudd opened this issue Mar 7, 2025 · 0 comments

Comments

@seanbudd
Copy link
Member

seanbudd commented Mar 7, 2025

Related issues, PRs or discussions

Fixup #17744

What is the current state of the codebase?

pyright runs on pre-commit locally, but is not triggered on the CI.
I think it's due to the names having conflict between the CI and local script.

Why are changes required?

As of #17745 , lint checks are no longer run on appveyor. this means that pyright is not running in CI at all.

What technical changes are required?

Ensure the pre-commit CI runs pyright.
If that's not possible, use an independent github action.

Are the proposed technical changes API breaking?

No

Are there potential risks or issues with the proposed implementation?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant