Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi Instance: Refactor: nvim-tree.explorer.filters #2828

Closed
alex-courtis opened this issue Jul 13, 2024 · 0 comments · Fixed by #2841
Closed

Multi Instance: Refactor: nvim-tree.explorer.filters #2828

alex-courtis opened this issue Jul 13, 2024 · 0 comments · Fixed by #2841
Assignees
@raaymax
Labels
PR please nvim-tree team does not have the bandwidth to implement; a PR will be gratefully appreciated
Milestone
Multi Instance - ...

Comments

@alex-courtis
Copy link
Member

alex-courtis commented Jul 13, 2024 •
edited
Loading

nvim-tree.explorer.filters is a stateful singleton. Make it an instantiable class owned by Explorer.

All usages must go through the TreeExplorer singleton.
@alex-courtis alex-courtis changed the title Multi Instance nvim-tree.explorer.filters Multi Instance: Refactor: nvim-tree.explorer.filters Jul 13, 2024
@alex-courtis alex-courtis added the PR please nvim-tree team does not have the bandwidth to implement; a PR will be gratefully appreciated label Jul 13, 2024
@raaymax raaymax self-assigned this Jul 17, 2024
raaymax added a commit that referenced this issue Jul 17, 2024
@raaymax
refactor(#2828): multi instance nvim-tree.explorer.filters
3ea906a
@alex-courtis alex-courtis moved this from Ready to In review in Multiple Instances Jul 20, 2024
@alex-courtis alex-courtis moved this from In review to Ready in Multiple Instances Jul 20, 2024
@alex-courtis alex-courtis mentioned this issue Jul 20, 2024
Merged
@alex-courtis alex-courtis moved this from Ready to In review in Multiple Instances Jul 20, 2024
alex-courtis added a commit that referenced this issue Jul 27, 2024
@raaymax @alex-courtis
refactor(#2828): multi instance nvim-tree.explorer.filters (#2841)
908478a 
* refactor(#2828): multi instance nvim-tree.explorer.filters

* fix: style

* fix: apply suggestions from code review

Co-authored-by: Alexander Courtis <[email protected]>

---------

Co-authored-by: Alexander Courtis <[email protected]>
@github-project-automation github-project-automation bot moved this from In review to Done in Multiple Instances Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raaymax raaymax

Labels
PR please nvim-tree team does not have the bandwidth to implement; a PR will be gratefully appreciated
Projects
Multiple Instances
Status: Done
Milestone
Multi Instance - 1 - Refactor
Development

Successfully merging a pull request may close this issue.

refactor(#2828): multi instance nvim-tree.explorer.filters nvim-tree/nvim-tree.lua
2 participants
@raaymax @alex-courtis