Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi Instance: Refactor: nvim-tree.explorer.sorters #2829

Closed
alex-courtis opened this issue Jul 13, 2024 · 1 comment · Fixed by #2835
Closed

Multi Instance: Refactor: nvim-tree.explorer.sorters #2829

alex-courtis opened this issue Jul 13, 2024 · 1 comment · Fixed by #2835
Assignees
@raaymax
Labels
PR please nvim-tree team does not have the bandwidth to implement; a PR will be gratefully appreciated
Milestone
Multi Instance - ...

Comments

@alex-courtis
Copy link
Member

alex-courtis commented Jul 13, 2024 •
edited
Loading

nvim-tree.explorer.sorters is a stateful singleton. Make it an instantiable class owned by Explorer.

All usages must go through the TreeExplorer singleton.
@alex-courtis alex-courtis changed the title Multi Instance nvim-tree.explorer.sorters Multi Instance: Refactor: nvim-tree.explorer.sorters Jul 13, 2024
@alex-courtis alex-courtis added the PR please nvim-tree team does not have the bandwidth to implement; a PR will be gratefully appreciated label Jul 13, 2024
@raaymax raaymax mentioned this issue Jul 13, 2024
Merged
@raaymax
Copy link
Collaborator

raaymax commented Jul 13, 2024

#2835

@alex-courtis alex-courtis moved this from Ready to In review in Multiple Instances Jul 14, 2024
alex-courtis added a commit that referenced this issue Jul 27, 2024
@raaymax @alex-courtis
refactor(#2829): multi instance nvim-tree.explorer.sorters (#2835)
82ba116 
* refactor: multi instance nvim-tree.explorer.sorters

* fix: linter errors

* fix: style

* fix: according to code review

* chore: removed comment

* fix: missing cfg params in sorters

* tidy following rebase

* tidy following rebase

---------

Co-authored-by: Alexander Courtis <[email protected]>
@github-project-automation github-project-automation bot moved this from In review to Done in Multiple Instances Jul 27, 2024
@alex-courtis alex-courtis mentioned this issue Mar 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raaymax raaymax

Labels
PR please nvim-tree team does not have the bandwidth to implement; a PR will be gratefully appreciated
Projects
Multiple Instances
Status: Done
Milestone
Multi Instance - 1 - Refactor
Development

Successfully merging a pull request may close this issue.

refactor(#2829): multi instance nvim-tree.explorer.sorters raaymax/nvim-tree.lua
2 participants
@raaymax @alex-courtis