Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi Instance: Refactor: Node Back References To Explorer #2871

Closed
alex-courtis opened this issue Aug 17, 2024 · 0 comments · Fixed by #2916
Closed

Multi Instance: Refactor: Node Back References To Explorer #2871

alex-courtis opened this issue Aug 17, 2024 · 0 comments · Fixed by #2916
Milestone
Multi Instance - ...

Comments

@alex-courtis
Copy link
Member

alex-courtis commented Aug 17, 2024 •
edited
Loading

Requires #2886

Add back references to explorer for all nodes.

This should eliminate many cyclic requires.

Watchers will need the explorer added to create_watcher
@alex-courtis alex-courtis converted this from a draft issue Aug 17, 2024
@alex-courtis alex-courtis added the PR please nvim-tree team does not have the bandwidth to implement; a PR will be gratefully appreciated label Aug 17, 2024
@alex-courtis alex-courtis removed the PR please nvim-tree team does not have the bandwidth to implement; a PR will be gratefully appreciated label Sep 23, 2024
@alex-courtis alex-courtis changed the title Multi Instance: Node Back References To Explorer Multi Instance: Refactor: Node Back References To Explorer Oct 5, 2024
@alex-courtis alex-courtis mentioned this issue Oct 7, 2024
Merged
alex-courtis added a commit that referenced this issue Oct 7, 2024
@alex-courtis
refactor(#2871, #2886): multi instance: node classes created (#2916)
38aac09 
* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* node classes and constructors

* node methods

* refactor(#2875): multi instance renderer

* node classes and constructors

* explorer is a directory node

* extract methods from explore_node

* extract methods from explore_node

* extract methods from explore_node

* extract methods from lib

* use .. name for root node for compatibility

* use node.explorer

* extract node factory, remove unused code

* factories for all nodes, add RootNode

* factories for all nodes, add RootNode

* use factory pattern for decorators

* note regression and commit

* fix dir git status regression

* destroy nodes, not explorer

* add BaseNode:is

* revert changes to create-file, handle in #2924

* extract methods from explorer

* extract methods from explorer

* extract methods from explorer

* use Node everywhere in luadoc

* extract methods from lib

* extract methods from lib

* lint

* remove unused code

* don't call methods on fake root node

* get_node_at_cursor returns explorer (root) node instead of { name = '..' }

* remove unused inject_node

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* extract methods from lib

* node factory uses stat only

* temporary DirectoryNode casting until method extraction into child classes

* lua-language-server 3.10.5 -> 3.11.0

* explicitly call Explorer constructor

* normalise explorer RootNode new call, tidy annotations
@github-project-automation github-project-automation bot moved this from In progress to Done in Multiple Instances Oct 7, 2024
alex-courtis added a commit that referenced this issue Oct 8, 2024
@alex-courtis
Revert "refactor(#2871, #2886): multi instance: node classes created (#…
50e9194 
…2916)"

This reverts commit 38aac09.
alex-courtis added a commit that referenced this issue Oct 11, 2024
@alex-courtis
Reapply "refactor(#2871, #2886): multi instance: node classes created (…
751410b 
…#2916)"

This reverts commit 50e9194.
alex-courtis added a commit that referenced this issue Oct 11, 2024
@alex-courtis
fix(#2945): stack overflow on api.git.reload or fugitive event with w…
5ad8762 
…atchers disabled (#2949)

* Reapply "refactor(#2871, #2886): multi instance: node classes created (#2916)"

This reverts commit 50e9194.

* fix(#2945): stack overflow on api.git.reload or fugitive event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Multiple Instances
Status: Done
Milestone
Multi Instance - 1 - Refactor
Development

Successfully merging a pull request may close this issue.

refactor(#2871, #2886): multi instance: node classes created nvim-tree/nvim-tree.lua
1 participant
@alex-courtis