Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi Instance: Refactor: move renderer into explorer #2875

Closed
alex-courtis opened this issue Aug 18, 2024 · 0 comments · Fixed by #2900
Closed

Multi Instance: Refactor: move renderer into explorer #2875

alex-courtis opened this issue Aug 18, 2024 · 0 comments · Fixed by #2900
Assignees
@alex-courtis
Milestone
Multi Instance - ...

Comments

@alex-courtis
Copy link
Member

Renderer / builder etc. appear to be stateful singletons.

They are not particularly stateful and have ~zero instantiation cost.

Explorer and components are accessed by a great many of them.

Instantiate renderer as an explorer member:

  • Simplifies calls to draw etc.
  • Allows rendering components access to explorer components
@alex-courtis alex-courtis self-assigned this Sep 9, 2024
alex-courtis added a commit that referenced this issue Sep 9, 2024
@alex-courtis
refactor(#2875): multi instance renderer
44f8aaa
alex-courtis added a commit that referenced this issue Sep 9, 2024
@alex-courtis
refactor(#2875): multi instance renderer
2dde0df
alex-courtis added a commit that referenced this issue Sep 9, 2024
@alex-courtis
refactor(#2875): multi instance renderer
be8f0eb
alex-courtis added a commit that referenced this issue Sep 9, 2024
@alex-courtis
refactor(#2875): multi instance renderer
0b304b8
alex-courtis added a commit that referenced this issue Sep 9, 2024
@alex-courtis
refactor(#2875): deal with some cyclic require
f78ee8f
alex-courtis added a commit that referenced this issue Sep 9, 2024
@alex-courtis
refactor(#2875): multi instance renderer
b1b8d3b
This was referenced Sep 9, 2024
Merged
Closed
alex-courtis added a commit that referenced this issue Sep 14, 2024
@alex-courtis
refactor(#2875): multi instance renderer
40b3432
alex-courtis added a commit that referenced this issue Sep 14, 2024
@alex-courtis
refactor(#2875): multi instance renderer
f4d74cd
alex-courtis added a commit that referenced this issue Sep 14, 2024
@alex-courtis
refactor(#2875): multi instance renderer
8f6dcc0
alex-courtis added a commit that referenced this issue Sep 14, 2024
@alex-courtis
refactor(#2875): multi instance renderer
fe1974c
alex-courtis added a commit that referenced this issue Sep 14, 2024
@alex-courtis
refactor(#2875): deal with some cyclic require
9add2e7
alex-courtis added a commit that referenced this issue Sep 14, 2024
@alex-courtis
refactor(#2875): multi instance renderer
9735e00
alex-courtis added a commit that referenced this issue Sep 14, 2024
@alex-courtis
refactor(#2875): multi instance renderer
2f404ec
alex-courtis added a commit that referenced this issue Sep 14, 2024
@alex-courtis
refactor(#2875): multi instance renderer
7212b44
alex-courtis added a commit that referenced this issue Sep 14, 2024
@alex-courtis
refactor(#2875): multi instance renderer
0014008
alex-courtis added a commit that referenced this issue Sep 14, 2024
@alex-courtis
refactor(#2875): multi instance renderer
c866a37
alex-courtis added a commit that referenced this issue Sep 14, 2024
@alex-courtis
refactor(#2875): multi instance renderer
f5e795a
alex-courtis added a commit that referenced this issue Sep 15, 2024
@alex-courtis
refactor(#2875): multi instance renderer
8ff10ce
alex-courtis added a commit that referenced this issue Sep 15, 2024
@alex-courtis
refactor(#2875): multi instance renderer
fb01d1a
alex-courtis added a commit that referenced this issue Sep 15, 2024
@alex-courtis
refactor(#2875): multi instance renderer
f7e545a
alex-courtis added a commit that referenced this issue Sep 15, 2024
@alex-courtis
refactor(#2875): multi instance renderer
e332271
alex-courtis added a commit that referenced this issue Sep 16, 2024
@alex-courtis
refactor(#2875): multi instance renderer
b1eb870
alex-courtis added a commit that referenced this issue Sep 21, 2024
@alex-courtis
refactor(#2875): multi instance renderer (#2900)
03ae603 
* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): deal with some cyclic require

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer
alex-courtis added a commit that referenced this issue Sep 21, 2024
@alex-courtis
refactor(#2875): multi instance renderer
aa33e9f
alex-courtis added a commit that referenced this issue Sep 21, 2024
@alex-courtis
refactor(#2875): multi instance renderer
0abef96
alex-courtis added a commit that referenced this issue Sep 21, 2024
@alex-courtis
refactor(#2875): multi instance renderer
48a80d1
alex-courtis added a commit that referenced this issue Sep 22, 2024
@alex-courtis
refactor(#2875): multi instance renderer: remove unused code
34d886d
alex-courtis added a commit that referenced this issue Sep 22, 2024
@alex-courtis
refactor(#2875): multi instance renderer: remove unused code (#2919)
0ae9ad4
alex-courtis added a commit that referenced this issue Sep 22, 2024
@alex-courtis
revert(#2794): sshfs compatibility (#2920)
8405ecf 
* refactor(#2875): multi instance renderer: remove unused code

* Revert "fix(#2794): sshfs compatibility (#2893)"

This reverts commit 2d6e64d.
alex-courtis added a commit that referenced this issue Sep 22, 2024
@alex-courtis
refactor(#2875): multi instance renderer
a6bfc1f
alex-courtis added a commit that referenced this issue Sep 22, 2024
@alex-courtis
refactor(#2875): multi instance renderer
ca0940c
alex-courtis added a commit that referenced this issue Sep 22, 2024
@alex-courtis
refactor(#2875): multi instance renderer
bfe2e6b
alex-courtis added a commit that referenced this issue Sep 22, 2024
@alex-courtis
refactor(#2875): multi instance renderer
568ca7f
alex-courtis added a commit that referenced this issue Sep 22, 2024
@alex-courtis
refactor(#2875): multi instance renderer
2dfe032
alex-courtis added a commit that referenced this issue Sep 29, 2024
@alex-courtis
refactor(#2875): multi instance renderer
1e13176
alex-courtis added a commit that referenced this issue Sep 29, 2024
@alex-courtis
refactor(#2875): multi instance renderer
f35e786
alex-courtis added a commit that referenced this issue Sep 29, 2024
@alex-courtis
refactor(#2875): multi instance renderer
596e051
alex-courtis added a commit that referenced this issue Sep 29, 2024
@alex-courtis
refactor(#2875): multi instance renderer
58e8cc2
alex-courtis added a commit that referenced this issue Sep 29, 2024
@alex-courtis
refactor(#2875): multi instance renderer
c318ecb
alex-courtis added a commit that referenced this issue Sep 30, 2024
@alex-courtis
refactor(#2875): multi instance renderer
42fc54e
alex-courtis added a commit that referenced this issue Sep 30, 2024
@alex-courtis
refactor(#2875): multi instance renderer
ee662ed
alex-courtis added a commit that referenced this issue Sep 30, 2024
@alex-courtis
refactor(#2875): multi instance renderer
2ada8af
alex-courtis added a commit that referenced this issue Sep 30, 2024
@alex-courtis
refactor(#2875): multi instance renderer
6f67837
alex-courtis added a commit that referenced this issue Sep 30, 2024
@alex-courtis
refactor(#2875): multi instance renderer
320366e
alex-courtis added a commit that referenced this issue Oct 5, 2024
@alex-courtis
refactor(#2875): multi instance renderer
71c519b
alex-courtis added a commit that referenced this issue Oct 5, 2024
@alex-courtis
refactor(#2875): multi instance renderer
760b1bc
alex-courtis added a commit that referenced this issue Oct 5, 2024
@alex-courtis
refactor(#2875): multi instance renderer
2ce5f69
alex-courtis added a commit that referenced this issue Oct 5, 2024
@alex-courtis
refactor(#2875): multi instance renderer
15e65ea
alex-courtis added a commit that referenced this issue Oct 5, 2024
@alex-courtis
refactor(#2875): multi instance renderer
d3946a1
alex-courtis added a commit that referenced this issue Oct 6, 2024
@alex-courtis
refactor(#2875): multi instance renderer
7ae7a53
alex-courtis added a commit that referenced this issue Oct 6, 2024
@alex-courtis
refactor(#2875): multi instance renderer
a1dff3c
alex-courtis added a commit that referenced this issue Oct 6, 2024
@alex-courtis
refactor(#2875): multi instance renderer
98debc7
alex-courtis added a commit that referenced this issue Oct 7, 2024
@alex-courtis
refactor(#2871, #2886): multi instance: node classes created (#2916)
38aac09 
* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* node classes and constructors

* node methods

* refactor(#2875): multi instance renderer

* node classes and constructors

* explorer is a directory node

* extract methods from explore_node

* extract methods from explore_node

* extract methods from explore_node

* extract methods from lib

* use .. name for root node for compatibility

* use node.explorer

* extract node factory, remove unused code

* factories for all nodes, add RootNode

* factories for all nodes, add RootNode

* use factory pattern for decorators

* note regression and commit

* fix dir git status regression

* destroy nodes, not explorer

* add BaseNode:is

* revert changes to create-file, handle in #2924

* extract methods from explorer

* extract methods from explorer

* extract methods from explorer

* use Node everywhere in luadoc

* extract methods from lib

* extract methods from lib

* lint

* remove unused code

* don't call methods on fake root node

* get_node_at_cursor returns explorer (root) node instead of { name = '..' }

* remove unused inject_node

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* extract methods from lib

* node factory uses stat only

* temporary DirectoryNode casting until method extraction into child classes

* lua-language-server 3.10.5 -> 3.11.0

* explicitly call Explorer constructor

* normalise explorer RootNode new call, tidy annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-courtis alex-courtis

Labels
None yet
Projects
Multiple Instances
Status: Done
Milestone
Multi Instance - 1 - Refactor
Development

Successfully merging a pull request may close this issue.

refactor(#2875): multi instance renderer nvim-tree/nvim-tree.lua
1 participant
@alex-courtis