Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi Instance: Refactor: move lib functions into Explorer #2941

Closed
alex-courtis opened this issue Oct 5, 2024 · 1 comment · Fixed by #2964
Closed

Multi Instance: Refactor: move lib functions into Explorer #2941

alex-courtis opened this issue Oct 5, 2024 · 1 comment · Fixed by #2964
Assignees
@alex-courtis
Milestone
Multi Instance - ...

Comments

@alex-courtis
Copy link
Member

alex-courtis commented Oct 5, 2024 •
edited
Loading

Many lib functions operate on an Explorer, move them in.
@alex-courtis alex-courtis converted this from a draft issue Oct 5, 2024
@alex-courtis alex-courtis moved this from Backlog to Ready in Multiple Instances Oct 5, 2024
@alex-courtis alex-courtis mentioned this issue Oct 21, 2024
Merged
@alex-courtis alex-courtis changed the title Multi Instance: Refactor: move lib functions into Exlorer Multi Instance: Refactor: move lib functions into Explorer Oct 21, 2024
@alex-courtis alex-courtis self-assigned this Oct 21, 2024
@alex-courtis
Copy link
Member Author

Remaining functions are stateless (e.g. prompt) or will be addressed in the next milestone (e.g. open_view_and_draw).

alex-courtis added a commit that referenced this issue Oct 26, 2024
@alex-courtis
refactor(#2941): move lib methods to explorer (#2964)
f3efc25 
* add todo

* refactor(#2886): multi instance: node class refactoring: extract links, *_git_status (#2944)

* extract DirectoryLinkNode and FileLinkNode, move Node methods to children

* temporarily move DirectoryNode methods into BaseNode for easier reviewing

* move mostly unchanged DirectoryNode methods back to BaseNode

* tidy

* git.git_status_file takes an array

* update git status of links

* luacheck hack

* safer git_status_dir

* refactor(#2886): multi instance: node class refactoring: DirectoryNode:expand_or_collapse (#2957)

move expand_or_collapse to DirectoryNode

* refactor(#2886): multi instance: node group functions refactoring (#2959)

* move last_group_node to DirectoryNode

* move add BaseNode:as and more doc

* revert parameter name changes

* revert parameter name changes

* add Class

* move group methods into DN

* tidy group methods

* tidy group methods

* tidy group methods

* tidy group methods

* parent is DirectoryNode

* tidy expand all

* BaseNode -> Node

* move watcher to DirectoryNode

* last_group_node is DirectoryNode only

* simplify create-file

* simplify parent

* simplify collapse-all

* simplify live-filter

* style

* move lib.get_cursor_position to Explorer

* move lib.get_node_at_cursor to Explorer

* move lib.get_nodes to Explorer

* move place_cursor_on_node to Explorer

* resolve resource leak in purge_all_state

* move many autocommands into Explorer

* post merge tidy
@github-project-automation github-project-automation bot moved this from In progress to Done in Multiple Instances Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-courtis alex-courtis

Labels
None yet
Projects
Multiple Instances
Status: Done
Milestone
Multi Instance - 1 - Refactor
Development

Successfully merging a pull request may close this issue.

refactor(#2941): move lib methods to explorer nvim-tree/nvim-tree.lua
1 participant
@alex-courtis