Handle Absolute JAR Path #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes instances where the `jar` parameter is an absolute
path to the JAR file. Previously, the path for
```js
const java = new JavaCaller({
jar: "F:\\my-path\\file.jar",
});
```
would become `./F:\\my-path\\file.jar`. Now, it is kept as-is, allowing
absolute paths to be provided.
This commit fixes instances where the `jar` parameter is an absolute
path to the JAR file. Previously, the path for
```js
const java = new JavaCaller({
jar: "F:\\my-path\\file.jar",
});
```
would become `./F:\\my-path\\file.jar`. Now, it is kept as-is, allowing
absolute paths to be provided.
…e-java-caller into absolute-jar-path
|
@BrendanC23 the test class is failing, please can you have a look ?
|
This commit fixes the handling of absolute paths, switching from
`path.join()` to `path.isAbsolute()` to handle differing behavior for
different platforms.
`path.join()` works differently for Windows paths and Linux paths.
`path.join(".", "C:\\") === "C:\\"`
`path.join(".", "/home/test") === "home/test"`
The latter is missing a leading `/` and thus is no longer an
absolute path.
As described in [this issue](GHSA-37v4-cwgp-x353),
there was a NodeJS [security vulnerability](https://nodejs.org/en/blog/vulnerability/january-2025-security-releases)
that caused the behavior of `path.join()` to be changed. Newer versions
of Node will return a relative path in these instances, so
`path.join(".", "C:\\") === ".\\C:\\"`.
|
@nvuillam I made some changes to the PR. There is one test that is failing due to a timeout.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 89.91% 89.95% +0.04%
==========================================
Files 3 3
Lines 228 229 +1
==========================================
+ Hits 205 206 +1
Misses 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nvuillam
approved these changes
May 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables an absolute path to be passed as the
jarparameter. It resolves #104. A new test (that previously would have failed) has been added.Now, this code works:
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance