Skip to content

Commit f52c65d

Browse files
committed
Cleanup todo and traces
1 parent bb6e625 commit f52c65d

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

docs/own/todo.md

+1
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ new, workstack:
9292
Either make tab-background change color on being focused,
9393
make it more transparent or something or maybe use a thin window border?
9494
{think window border looks good imo}
95+
- [ ] cleanup: move out device_default stuff to gfr fork?
9596

9697
- [ ] (low prio, ui) sparse: for images, allow to show popup with bound
9798
memory on hover in imageViewer. Also bond-to-memory overlay

docs/own/workstack.md

+3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
- [ ] add serialize support for more commands (e.g. Bind)
22
- [ ] serialize further gui state, e.g. selected I/O
33
- [ ] better deep-matching for handles, especially pipelines
4+
- [ ] ~hook.cpp:777 TODO PERF: clear out non-reuse hooked records
5+
- [ ] optimize acceleration structure capturing
6+
- optimal: when UI is not open, don't allocate on every rebuilt
47
- [ ] support viewing a specific array element in the buffer formatter
58
- [ ] we might not even copy the needed data for some elements.
69
Only copy the needed data, we already have paging for the gui

src/gui/command.cpp

+1-5
Original file line numberDiff line numberDiff line change
@@ -1059,11 +1059,7 @@ void CommandViewer::displayDs(Draw& draw) {
10591059

10601060
auto& instances = std::get<AccelInstances>(capture->tlas->data);
10611061

1062-
// TODO: also display other instance information
1063-
dlg_trace("{} inis", instances.instances.size());
1064-
dlg_trace(" [0]: {}", instances.instances[0].accelerationStructureReference);
1065-
dlg_trace(" [1]: {}", instances.instances[1].accelerationStructureReference);
1066-
dlg_trace(" [2]: {}", instances.instances[2].accelerationStructureReference);
1062+
// TODO: also display instance information
10671063

10681064
vertexViewer_.displayInstances(draw, instances, gui_->dt(), resolveBlas);
10691065
} else if(dsCat == DescriptorCategory::inlineUniformBlock) {

0 commit comments

Comments
 (0)