Ensure Cr is always a correct value

Author: ChristopherRabotin

src/cosmic/spacecraft.rs

@@ -497,7 +497,7 @@ impl State for Spacecraft {
         self.orbit.epoch = epoch;
         self.orbit.radius_km = radius_km;
         self.orbit.velocity_km_s = vel_km_s;
-        self.srp.cr = sc_state[6];
+        self.srp.cr = sc_state[6].clamp(0.0, 2.0);
         self.drag.cd = sc_state[7];
         self.fuel_mass_kg = sc_state[8];
     }
@@ -788,7 +788,7 @@ impl Add<OVector<f64, Const<9>>> for Spacecraft {
 
         self.orbit.radius_km += radius_km;
         self.orbit.velocity_km_s += vel_km_s;
-        self.srp.cr += other[6];
+        self.srp.cr = (self.srp.cr + other[6]).clamp(0.0, 2.0);
         self.drag.cd += other[7];
         self.fuel_mass_kg += other[8];
 

tests/orbit_determination/spacecraft.rs

@@ -446,8 +446,8 @@ fn od_val_sc_srp_estimation(
     assert!(delta.rmag_km() < 1e-3, "More than 1 meter error");
     assert!(delta.vmag_km_s() < 1e-6, "More than 1 millimeter/s error");
     assert!(
-        (est.state().srp.cr - truth_cr).abs() < 0.377,
-        "Cr estimation did not decrease"
+        (est.state().srp.cr - truth_cr).abs() < 0.038,
+        "Cr estimation worst than expected"
     );
 
     for (no, est) in odp.estimates.iter().enumerate() {