Skip to content

Commit db32d1c

Browse files
feat: unified naming of the related objects in the api-harmonization and frontend apps
* feat: unified naming of the related objects in the api-harmonization and frontend apps - from now on, they are called `blocks` (instead od `components` in api-harmonization and `containers` in frontend) * fix(frontend): reverted change with dynamic components as it caused them to be rendered twice on page load
1 parent 3d68383 commit db32d1c

File tree

287 files changed

+1279
-1385
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

287 files changed

+1279
-1385
lines changed

.changeset/small-days-pretend.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
'@o2s/prettier-config': minor
3+
'@o2s/integrations.strapi-cms': minor
4+
'@o2s/integrations.mocked': minor
5+
'@o2s/api-harmonization': minor
6+
'@o2s/framework': minor
7+
'@o2s/frontend': minor
8+
'@o2s/docs': minor
9+
---
10+
11+
unified naming of the related objects in the api-harmonization and frontend apps - from now on, they are called `blocks` (instead of `components` in api-harmonization and `containers` in frontend)

apps/api-harmonization/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"license": "MIT",
88
"exports": {
99
".": "./src/index.ts",
10-
"./components": "./src/components/index.ts",
10+
"./blocks": "./src/blocks/index.ts",
1111
"./modules": "./src/modules/index.ts"
1212
},
1313
"scripts": {

apps/api-harmonization/src/app.module.ts

Lines changed: 28 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -19,21 +19,21 @@ import {
1919
Users,
2020
} from '@o2s/framework/modules';
2121

22-
// COMPONENT IMPORT
22+
// BLOCK IMPORT
2323
import { configuration } from '@o2s/api-harmonization/config/configuration';
2424

25-
import { ArticleDetailsComponentModule } from '@o2s/api-harmonization/components/article-details/article-details.module';
26-
import { ArticleListComponentModule } from '@o2s/api-harmonization/components/article-list/article-list.module';
27-
import { FaqComponentModule } from '@o2s/api-harmonization/components/faq/faq.module';
28-
import { InvoiceListComponentModule } from '@o2s/api-harmonization/components/invoice-list/invoice-list.module';
29-
import { NotificationDetailsComponentModule } from '@o2s/api-harmonization/components/notification-details/notification-details.module';
30-
import { NotificationListComponentModule } from '@o2s/api-harmonization/components/notification-list/notification-list.module';
31-
import { PaymentsHistoryComponentModule } from '@o2s/api-harmonization/components/payments-history/payments-history.module';
32-
import { PaymentsSummaryComponentModule } from '@o2s/api-harmonization/components/payments-summary/payments-summary.module';
33-
import { TicketDetailsComponentModule } from '@o2s/api-harmonization/components/ticket-details/ticket-details.module';
34-
import { TicketListComponentModule } from '@o2s/api-harmonization/components/ticket-list/ticket-list.module';
35-
import { TicketRecentComponentModule } from '@o2s/api-harmonization/components/ticket-recent/ticket-recent.module';
36-
import { UserAccountComponentModule } from '@o2s/api-harmonization/components/user-account/user-account.module';
25+
import { ArticleDetailsBlockModule } from '@o2s/api-harmonization/blocks/article-details/article-details.module';
26+
import { ArticleListBlockModule } from '@o2s/api-harmonization/blocks/article-list/article-list.module';
27+
import { FaqBlockModule } from '@o2s/api-harmonization/blocks/faq/faq.module';
28+
import { InvoiceListBlockModule } from '@o2s/api-harmonization/blocks/invoice-list/invoice-list.module';
29+
import { NotificationDetailsBlockModule } from '@o2s/api-harmonization/blocks/notification-details/notification-details.module';
30+
import { NotificationListBlockModule } from '@o2s/api-harmonization/blocks/notification-list/notification-list.module';
31+
import { PaymentsHistoryBlockModule } from '@o2s/api-harmonization/blocks/payments-history/payments-history.module';
32+
import { PaymentsSummaryBlockModule } from '@o2s/api-harmonization/blocks/payments-summary/payments-summary.module';
33+
import { TicketDetailsBlockModule } from '@o2s/api-harmonization/blocks/ticket-details/ticket-details.module';
34+
import { TicketListBlockModule } from '@o2s/api-harmonization/blocks/ticket-list/ticket-list.module';
35+
import { TicketRecentBlockModule } from '@o2s/api-harmonization/blocks/ticket-recent/ticket-recent.module';
36+
import { UserAccountBlockModule } from '@o2s/api-harmonization/blocks/user-account/user-account.module';
3737

3838
import { AppConfig } from './app.config';
3939
import { AppService } from './app.service';
@@ -71,18 +71,21 @@ import { RoutesModule } from './modules/routes/routes.module';
7171
LoginPageModule.register(AppConfig),
7272
NotFoundPageModule.register(AppConfig),
7373

74-
TicketListComponentModule.register(AppConfig),
75-
TicketDetailsComponentModule.register(AppConfig),
76-
NotificationListComponentModule.register(AppConfig),
77-
NotificationDetailsComponentModule.register(AppConfig),
78-
FaqComponentModule.register(AppConfig),
79-
ArticleDetailsComponentModule.register(AppConfig),
80-
ArticleListComponentModule.register(AppConfig),
81-
InvoiceListComponentModule.register(AppConfig),
82-
PaymentsSummaryComponentModule.register(AppConfig),
83-
PaymentsHistoryComponentModule.register(AppConfig),
84-
UserAccountComponentModule.register(AppConfig),
85-
TicketRecentComponentModule.register(AppConfig),
74+
TicketListBlockModule.register(AppConfig),
75+
TicketDetailsBlockModule.register(AppConfig),
76+
NotificationListBlockModule.register(AppConfig),
77+
NotificationDetailsBlockModule.register(AppConfig),
78+
FaqBlockModule.register(AppConfig),
79+
Articles.Module.register(AppConfig),
80+
ArticleDetailsBlockModule.register(AppConfig),
81+
ArticleListBlockModule.register(AppConfig),
82+
Resources.Module.register(AppConfig),
83+
Invoices.Module.register(AppConfig),
84+
InvoiceListBlockModule.register(AppConfig),
85+
PaymentsSummaryBlockModule.register(AppConfig),
86+
PaymentsHistoryBlockModule.register(AppConfig),
87+
UserAccountBlockModule.register(AppConfig),
88+
TicketRecentBlockModule.register(AppConfig),
8689
// COMPONENT REGISTER
8790
],
8891
providers: [

apps/api-harmonization/src/components/article-details/article-details.controller.ts renamed to apps/api-harmonization/src/blocks/article-details/article-details.controller.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { LoggerService } from '@o2s/utils.logger';
44
import { AppHeaders } from '@o2s/api-harmonization/utils/headers';
55

66
import { URL } from './';
7-
import { GetArticleDetailsComponentParams, GetArticleDetailsComponentQuery } from './article-details.request';
7+
import { GetArticleDetailsBlockParams, GetArticleDetailsBlockQuery } from './article-details.request';
88
import { ArticleDetailsService } from './article-details.service';
99

1010
@Controller(URL)
@@ -13,11 +13,11 @@ export class ArticleDetailsController {
1313
constructor(protected readonly service: ArticleDetailsService) {}
1414

1515
@Get(':id')
16-
getArticleDetailsComponent(
16+
getArticleDetailsBlock(
1717
@Headers() headers: AppHeaders,
18-
@Query() query: GetArticleDetailsComponentQuery,
19-
@Param() params: GetArticleDetailsComponentParams,
18+
@Query() query: GetArticleDetailsBlockQuery,
19+
@Param() params: GetArticleDetailsBlockParams,
2020
) {
21-
return this.service.getArticleDetailsComponent(query, params, headers);
21+
return this.service.getArticleDetailsBlock(query, params, headers);
2222
}
2323
}

apps/api-harmonization/src/components/article-details/article-details.mapper.ts renamed to apps/api-harmonization/src/blocks/article-details/article-details.mapper.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@ import { Articles, CMS } from '@o2s/framework/modules';
22

33
import { formatDateRelative } from '@o2s/api-harmonization/utils/date';
44

5-
import { Article, ArticleDetailsComponent, ArticleSection } from './article-details.model';
5+
import { Article, ArticleDetailsBlock, ArticleSection } from './article-details.model';
66

77
export const mapArticleDetails = (
88
article: Articles.Model.Article,
9-
cms: CMS.Model.ArticleDetailsComponent.ArticleDetailsComponent,
9+
cms: CMS.Model.ArticleDetailsBlock.ArticleDetailsBlock,
1010
locale: string,
11-
): ArticleDetailsComponent => {
11+
): ArticleDetailsBlock => {
1212
return {
13-
__typename: 'ArticleDetailsComponent',
13+
__typename: 'ArticleDetailsBlock',
1414
data: {
1515
id: article.id,
1616
title: article.title,
@@ -21,12 +21,12 @@ export const mapArticleDetails = (
2121
thumbnail: article.thumbnail,
2222
sections: mapSections(article.sections),
2323
},
24-
} as ArticleDetailsComponent;
24+
} as ArticleDetailsBlock;
2525
};
2626

2727
export const mapArticle = (
2828
article: Articles.Model.Article,
29-
cms: CMS.Model.ArticleDetailsComponent.ArticleDetailsComponent,
29+
cms: CMS.Model.ArticleDetailsBlock.ArticleDetailsBlock,
3030
locale: string,
3131
): Article => {
3232
return {

apps/api-harmonization/src/components/article-details/article-details.model.ts renamed to apps/api-harmonization/src/blocks/article-details/article-details.model.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { Articles } from '@o2s/framework/modules';
22

3-
import { Component } from '../../utils';
3+
import { Block } from '../../utils';
44

5-
export class ArticleDetailsComponent extends Component.Component {
6-
__typename!: 'ArticleDetailsComponent';
5+
export class ArticleDetailsBlock extends Block.Block {
6+
__typename!: 'ArticleDetailsBlock';
77
data!: Article;
88
}
99

apps/api-harmonization/src/components/article-details/article-details.module.ts renamed to apps/api-harmonization/src/blocks/article-details/article-details.module.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@ import { ArticleDetailsController } from './article-details.controller';
77
import { ArticleDetailsService } from './article-details.service';
88

99
@Module({})
10-
export class ArticleDetailsComponentModule {
10+
export class ArticleDetailsBlockModule {
1111
static register(config: ApiConfig): DynamicModule {
1212
const cmsService = config.integrations.cms.service;
1313
const articleService = config.integrations.articles.service;
1414
const searchService = config.integrations.search.service;
1515

1616
return {
17-
module: ArticleDetailsComponentModule,
17+
module: ArticleDetailsBlockModule,
1818
providers: [
1919
ArticleDetailsService,
2020
{
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
import { Articles, CMS } from '@o2s/framework/modules';
2+
3+
export class GetArticleDetailsBlockQuery implements Omit<CMS.Request.GetCmsEntryParams, 'locale'> {
4+
id!: string;
5+
}
6+
7+
export class GetArticleDetailsBlockParams implements Omit<Articles.Request.GetArticleParams, 'locale'> {
8+
id!: string;
9+
}

apps/api-harmonization/src/components/article-details/article-details.service.ts renamed to apps/api-harmonization/src/blocks/article-details/article-details.service.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import { Articles, CMS } from '@o2s/framework/modules';
66
import { AppHeaders } from '@o2s/api-harmonization/utils/headers';
77

88
import { mapArticleDetails } from './article-details.mapper';
9-
import { ArticleDetailsComponent } from './article-details.model';
10-
import { GetArticleDetailsComponentParams, GetArticleDetailsComponentQuery } from './article-details.request';
9+
import { ArticleDetailsBlock } from './article-details.model';
10+
import { GetArticleDetailsBlockParams, GetArticleDetailsBlockQuery } from './article-details.request';
1111

1212
@Injectable()
1313
export class ArticleDetailsService {
@@ -16,12 +16,12 @@ export class ArticleDetailsService {
1616
private readonly articleService: Articles.Service,
1717
) {}
1818

19-
getArticleDetailsComponent(
20-
query: GetArticleDetailsComponentQuery,
21-
params: GetArticleDetailsComponentParams,
19+
getArticleDetailsBlock(
20+
query: GetArticleDetailsBlockQuery,
21+
params: GetArticleDetailsBlockParams,
2222
headers: AppHeaders,
23-
): Observable<ArticleDetailsComponent> {
24-
const cms = this.cmsService.getArticleDetailsComponent({ ...query, locale: headers['x-locale'] });
23+
): Observable<ArticleDetailsBlock> {
24+
const cms = this.cmsService.getArticleDetailsBlock({ ...query, locale: headers['x-locale'] });
2525
const article = this.articleService.getArticle({ ...params, locale: headers['x-locale'] });
2626

2727
return forkJoin([article, cms]).pipe(
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export const URL = '/components/article-details';
1+
export const URL = '/blocks/article-details';
22

33
export * as Model from './article-details.model';
44
export * as Request from './article-details.request';

0 commit comments

Comments
 (0)