Fix

rui-mo · rui-mo · commit 2c674af994fb · 2023-09-11T11:04:48.000+08:00
diff --git a/velox/functions/sparksql/aggregates/DecimalSumAggregate.h b/velox/functions/sparksql/aggregates/DecimalSumAggregate.h
@@ -74,7 +74,7 @@ class DecimalSumAggregate : public exec::Aggregate {
 
     auto [resultPrecision, resultScale] =
         getDecimalPrecisionScale(*sumType_.get());
-    overflow = !DecimalUtil::valueInRangeWithPrecision(sum, resultPrecision);
+    overflow = !DecimalUtil::valueInPrecisionRange(sum, resultPrecision);
     return sum;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ class DecimalSumAggregate : public exec::Aggregate {`
`74`	`74`
`75`	`75`	`auto [resultPrecision, resultScale] =`
`76`	`76`	`getDecimalPrecisionScale(*sumType_.get());`
`77`		`- overflow = !DecimalUtil::valueInRangeWithPrecision(sum, resultPrecision);`
	`77`	`+ overflow = !DecimalUtil::valueInPrecisionRange(sum, resultPrecision);`
`78`	`78`	`return sum;`
`79`	`79`	`}`
`80`	`80`