Skip to content

Commit e4288dd

Browse files
authored
Merge pull request #2589 from objectcomputing/bugfix-2542/adding-a-supervisor-in-reviews
Bugfix 2542/adding a supervisor in reviews
2 parents 20b0486 + 9196337 commit e4288dd

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

web-ui/src/components/reviews/TeamReviews.jsx

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ const TeamReviews = ({ onBack, periodId }) => {
225225
revieweeId: tm.id,
226226
reviewerId: tm.supervisorid,
227227
reviewPeriodId: periodId,
228-
approved: true
228+
approved: false
229229
}));
230230

231231
const res = await resolve({
@@ -241,8 +241,21 @@ const TeamReviews = ({ onBack, periodId }) => {
241241
if (res.error) return;
242242

243243
setTeamMembers(teamMembers);
244+
addAssignmentForMemberWithNone(teamMembers);
244245
};
245246

247+
const addAssignmentForMemberWithNone = async (members) => {
248+
members.forEach(member => {
249+
const exists = assignments.some(
250+
a => a.revieweeId === member.id
251+
);
252+
if (!!!exists && member.supervisorid) {
253+
const reviewers = [{ id: member.supervisorid }];
254+
updateReviewers(member, reviewers);
255+
}
256+
});
257+
}
258+
246259
const getReviewStatus = useCallback(
247260
teamMemberId => {
248261
let reviewStates = { submitted: false, inProgress: false };

0 commit comments

Comments
 (0)