Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBO challenge 2023: go green in Uberon OBO dashboard #2053

Closed
paolaroncaglia opened this issue Sep 17, 2021 · 16 comments
Closed

OBO challenge 2023: go green in Uberon OBO dashboard #2053

paolaroncaglia opened this issue Sep 17, 2021 · 16 comments
Assignees
Labels

Comments

@paolaroncaglia
Copy link
Contributor

Similarly to obophenotype/cell-ontology#1262, placeholder ticket inspired by @matentzn 's talk at ICBO 2021. Here's the Uberon OBO dashboard report.

@matentzn
Copy link
Contributor

Thats the spirit! For technical reasons, the ROBOT report on the dashboard is truncated, but if you want the full list as a table, I will generate it for you!

@dosumis
Copy link
Contributor

dosumis commented Sep 20, 2021

Full would be useful. I think it's not as bad as it looks at first glance. e.g. - some obvious signs of pipeline/declaration issues.

@paolaroncaglia paolaroncaglia self-assigned this Sep 24, 2021
@paolaroncaglia
Copy link
Contributor Author

paolaroncaglia commented Sep 24, 2021

Self-assigning for shepherding purposes.
Not urgent, but to start with,

  • @matentzn could you please provide the full report.

We can then better assess what needs to be done, and think about assigning tasks. Some, like adding missing definitions, could be labelled Easy First Issue and kept for training purposes if there are plans for new curators starting soon-ish (or for anyone wishing to contribute).

@matentzn
Copy link
Contributor

https://github.com/obophenotype/uberon/blob/master/src/ontology/reports/uberon-edit.obo-obo-report.tsv

You can refresh with:

cd src/ontology
sh run.sh make IMP=false PAT=false robot_reports

but it will also be refreshed with every release.

@paolaroncaglia
Copy link
Contributor Author

@matentzn
Thanks for the speedy reply!
May I please ask to (no rush)

  • Add a column with IDs (useful to sort and filter out, e.g. some missing definitions are for non-Uberon terms)
  • Look into the INFO missing_superclass message. Terms I created are in there because they have an equivalent axiom and (as per David's instructions) I did not add the redundant superclass, e.g. the last one in the list. I checked a couple of terms created by others and they're the same, and there's a ton of them. (David suggested - signs of pipeline/declaration issues.) Should the missing_superclass check be changed to look for real cases, or excluded from the ROBOT dashboard report, or the check name changed to something less alarming? :-)

Then we can better focus on the error/warnings. Thanks.

@paolaroncaglia
Copy link
Contributor Author

P.S. @matentzn, I'll add you as assignee as you've worked on this.

@matentzn
Copy link
Contributor

I would only care about ERROR for now.. INFO ones leave them for last.

@paolaroncaglia
Copy link
Contributor Author

paolaroncaglia commented Feb 23, 2022

Update re. Uberon OBO dashboard for the latest version of Uberon (released Feb 21st 2022):

  1. 130 errors due to duplicate_definition
  2. 1145 warnings due to duplicate_scoped_synonym
  3. 2 missing_subset_declaration (not found in GitHub report)
  4. 743 warnings due to duplicate_label_synonym
  5. 2863 warnings due to missing_definition
  6. 187 info about lowercase_definition
  7. 2818 info about missing_superclass

Entries in 1. are classified as warnings, not errors, in the report generated in GitHub as part of the release, and have a dedicated ticket.

Entries in 2. also have a dedicated ticket .

Entries in 4. (I've spot-checked a few) are likely due to import of xref labels (e.g. from FMA) and seem to all affect same-same term (i.e. a term has an exact synonym that's identical to its primary label). These particular cases should probably not give rise to warnings; it's far more serious when an exact synonym of term A is identical to primary label of term B, but there are checks in place for that.

Entries in 5. will require a significant effort to tackle. Note they are not all Uberon terms - but mostly. Ideas:
Prioritise terms that are not in the UBERON:2X, 3X, 4X, 6X?
See if terms have logical axioms that could help generate automated textual definitions, similarly to obophenotype/cell-ontology#1262 (comment)?

@paolaroncaglia
Copy link
Contributor Author

@matentzn FYI I'll remove my assignment and add to the tech board. I hope the outline above helps ;-)

@shawntanzk
Copy link
Collaborator

shawntanzk commented Mar 14, 2022

@shawntanzk to look into non-RO relations http://dashboard.obofoundry.org/dashboard/uberon/fp7.html

eg http://purl.obolibrary.org/obo/uberon/core#synapsed_by should be a RO term - look into why it is there

Related to #1823

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@anitacaron
Copy link
Collaborator

anitacaron commented Feb 14, 2023

Currently, we have 129 errors related to the text definition. 126 of them are related to the definition being a simple dot. This will be fixed with the new ODK release.

Another error type is using UBERON namespace for two RO properties.

@github-actions github-actions bot removed the Stale label Feb 15, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@github-actions github-actions bot added the Stale label Sep 6, 2023
@anitacaron
Copy link
Collaborator

anitacaron commented Sep 6, 2023

Update today. The most urgent one is the duplicate definition error

Screenshot 2023-09-06 at 16 41 15

@matentzn matentzn removed their assignment Dec 11, 2023
@anitacaron
Copy link
Collaborator

Now that PR #2964 has been merged, Uberon won't have any errors in the next dashboard release.

@anitacaron
Copy link
Collaborator

Uberon is green in the last dashboard release (2024-01-24) 🎉

Screenshot 2024-01-24 at 15 50 29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants