Skip to content

Commit 194c866

Browse files
authored
Fix: fix thread knowledge dataset not being included (#1373)
Signed-off-by: Daishan Peng <[email protected]>
1 parent 3fde1ed commit 194c866

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

pkg/render/render.go

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,8 @@ func configureKnowledgeEnvs(ctx context.Context, db kclient.Client, agent *v1.Ag
212212
}
213213
}
214214

215+
var knowledgeDatasets []string
216+
var knowledgeDataDescriptions []string
215217
for _, knowledgeSetName := range knowledgeSetNames {
216218
var ks v1.KnowledgeSet
217219
if err := db.Get(ctx, kclient.ObjectKey{Namespace: agent.Namespace, Name: knowledgeSetName}, &ks); apierror.IsNotFound(err) {
@@ -236,10 +238,13 @@ func configureKnowledgeEnvs(ctx context.Context, db kclient.Client, agent *v1.Ag
236238
dataDescription = "No data description available"
237239
}
238240

239-
return append(extraEnv,
240-
fmt.Sprintf("KNOW_DATASETS=%s/%s", ks.Namespace, ks.Name),
241-
fmt.Sprintf("KNOW_DATASET_DESCRIPTION=%s", dataDescription),
242-
), true, nil
241+
knowledgeDatasets = append(knowledgeDatasets, fmt.Sprintf("%s/%s", ks.Namespace, ks.Name))
242+
knowledgeDataDescriptions = append(knowledgeDataDescriptions, dataDescription)
243+
}
244+
if len(knowledgeDatasets) > 0 {
245+
extraEnv = append(extraEnv, fmt.Sprintf("KNOW_DATASETS=%s", strings.Join(knowledgeDatasets, ",")))
246+
extraEnv = append(extraEnv, fmt.Sprintf("KNOW_DATA_DESCRIPTIONS=%s", strings.Join(knowledgeDataDescriptions, ",")))
247+
return extraEnv, true, nil
243248
}
244249

245250
return extraEnv, false, nil

0 commit comments

Comments
 (0)