fix: tests, enforce unhandled mocked requests (#1713)

ui/admin/test/mocks/handlers/tools.ts

@@ -9,6 +9,7 @@ import {
 	mockedWorkspaceFilesToolReference,
 } from "test/mocks/models/toolReferences";
 
+import { OAuthApp } from "~/lib/model/oauthApps";
 import { EntityList } from "~/lib/model/primitives";
 import { ToolReference } from "~/lib/model/toolReferences";
 import { ApiRoutes } from "~/lib/routers/apiRoutes";
@@ -33,4 +34,9 @@ export const toolsHandlers = [
 			items: mockedToolReferences,
 		});
 	}),
+	http.get(ApiRoutes.oauthApps.getOauthApps().path, () => {
+		return HttpResponse.json<EntityList<OAuthApp>>({
+			items: [],
+		});
+	}),
 ];

ui/admin/test/setup.ts

@@ -2,6 +2,12 @@ import "@testing-library/jest-dom";
 import { mutate } from "swr";
 import { server } from "test/server";
 
+declare module "vitest" {
+	interface Assertion {
+		notToHaveUnhandledCalls(): void;
+	}
+}
+
 // for ThemeProvider, mock window.matchMedia
 Object.defineProperty(window, "matchMedia", {
 	writable: true,
@@ -24,17 +30,46 @@ global.ResizeObserver = class ResizeObserver {
 	disconnect() {}
 };
 
+expect.extend({
+	notToHaveUnhandledCalls(received) {
+		const pass = received.mock.calls.length === 0;
+
+		if (!pass) {
+			const unhandledRequests = received.mock.calls
+				.map(([req]: [Request]) => `${req.method} ${req.url}`)
+				.join("\n  ");
+
+			return {
+				pass,
+				message: () =>
+					`[MSW] Error: intercepted a request without a matching request handler:\n\n  ${unhandledRequests}\n\n Make sure to add appropriate request handlers for these calls. \n Read more: https://mswjs.io/docs/getting-started/mocks`,
+			};
+		}
+		return { pass, message: () => "No unhandled calls detected" };
+	},
+});
+
+const onUnhandledRequest = vi.fn();
+
 // Establish API mocking before all tests
-beforeAll(() => server.listen());
+beforeAll(() =>
+	server.listen({
+		onUnhandledRequest: onUnhandledRequest,
+	})
+);
 
 beforeEach(() => {
 	// Clear the SWR cache before each test
 	mutate(() => true, undefined, { revalidate: true });
+	onUnhandledRequest.mockClear();
 });
 
 // Reset any request handlers that we may add during the tests,
 // so they don't affect other tests.
-afterEach(() => server.resetHandlers());
+afterEach(() => {
+	server.resetHandlers();
+	expect(onUnhandledRequest).notToHaveUnhandledCalls();
+});
 
 // Clean up after the tests are finished.
 afterAll(() => server.close());