From ee2ac7ec32f066fdd4dd472ea8cdee460ebbbf22 Mon Sep 17 00:00:00 2001
From: Donnie Adams <donnie@acorn.io>
Date: Wed, 18 Dec 2024 21:10:41 -0500
Subject: [PATCH] fix: update workflow tools more consistently

The useEffect updating on the watch is not effectively updating the tools for
workflows. This change switches back using the form.

Signed-off-by: Donnie Adams <donnie@acorn.io>
---
 ui/admin/app/components/tools/BasicToolForm.tsx | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ui/admin/app/components/tools/BasicToolForm.tsx b/ui/admin/app/components/tools/BasicToolForm.tsx
index cc91fdedb..ae7bc2588 100644
--- a/ui/admin/app/components/tools/BasicToolForm.tsx
+++ b/ui/admin/app/components/tools/BasicToolForm.tsx
@@ -34,7 +34,7 @@ export function BasicToolForm({
         resolver: zodResolver(formSchema),
         defaultValues: { tools: defaultValues?.tools || [] },
     });
-    const { watch, getValues, reset } = form;
+    const { getValues, reset } = form;
 
     useEffect(() => {
         const unchanged = compareArrays(
@@ -50,14 +50,14 @@ export function BasicToolForm({
     const toolArr = useFieldArray({ control: form.control, name: "tools" });
 
     useEffect(() => {
-        return watch((values) => {
+        return form.watch((values) => {
             const { data, success } = formSchema.safeParse(values);
 
             if (!success) return;
 
             onChange?.({ tools: data.tools.map((t) => t.value) });
         }).unsubscribe;
-    }, [watch, onChange]);
+    }, [form, onChange]);
 
     const removeTools = (toolsToRemove: string[]) => {
         const indexes = toolsToRemove